Skip to content

Commit 4329714

Browse files
chore: changes as per code review
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 751bc71 commit 4329714

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

lib/node_modules/@stdlib/stats/base/dists/geometric/quantile/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ for ( i = 0; i < 10; i++ ) {
171171
#include "stdlib/stats/base/dists/geometric/quantile.h"
172172
```
173173

174-
#### stdlib_base_dists_geometric_quantile( p, p_success )
174+
#### stdlib_base_dists_geometric_quantile( r, p )
175175

176176
Evaluates the [quantile function][quantile-function] for a [geometric][geometric-distribution] distribution with success probability `p` at a value `r`.
177177

@@ -182,8 +182,8 @@ double out = stdlib_base_dists_geometric_quantile( 0.5, 0.4 );
182182

183183
The function accepts the following arguments:
184184

185-
- **p**: `[in] double` input probability.
186-
- **p_success**: `[in] double` success probability.
185+
- **r**: `[in] double` input probability.
186+
- **p**: `[in] double` success probability.
187187

188188
```c
189189
double stdlib_base_dists_geometric_quantile( const double r, const double p );

lib/node_modules/@stdlib/stats/base/dists/geometric/quantile/manifest.json

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@
4141
"@stdlib/math/base/napi/binary",
4242
"@stdlib/math/base/assert/is-nan",
4343
"@stdlib/constants/float64/pinf",
44-
"@stdlib/math/base/special/ln"
44+
"@stdlib/math/base/special/ln",
45+
"@stdlib/math/base/special/floor"
4546
]
4647
},
4748
{
@@ -59,7 +60,8 @@
5960
"@stdlib/math/base/assert/is-nan",
6061
"@stdlib/constants/float64/pinf",
6162
"@stdlib/math/base/special/ln",
62-
"@stdlib/constants/float64/eps"
63+
"@stdlib/constants/float64/eps",
64+
"@stdlib/math/base/special/floor"
6365
]
6466
},
6567
{
@@ -76,7 +78,8 @@
7678
"dependencies": [
7779
"@stdlib/math/base/assert/is-nan",
7880
"@stdlib/constants/float64/pinf",
79-
"@stdlib/math/base/special/ln"
81+
"@stdlib/math/base/special/ln",
82+
"@stdlib/math/base/special/floor"
8083
]
8184
}
8285
]

lib/node_modules/@stdlib/stats/base/dists/geometric/quantile/src/main.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
#include "stdlib/math/base/assert/is_nan.h"
2121
#include "stdlib/constants/float64/pinf.h"
2222
#include "stdlib/math/base/special/ln.h"
23+
#include "stdlib/math/base/special/floor.h"
24+
#include "stdlib/math/base/special/max.h"
2325

2426
/**
2527
* Evaluates the quantile function of a geometric distribution.
@@ -46,5 +48,5 @@ double stdlib_base_dists_geometric_quantile( const double r, const double p ) {
4648
if( r == 1.0 ){
4749
return STDLIB_CONSTANT_FLOAT64_PINF;
4850
}
49-
return floor( stdlib_base_ln( 1.0 - r ) / stdlib_base_ln( 1.0 - p ) );
51+
return stdlib_base_max( 0.0, stdlib_base_floor( stdlib_base_ln( 1.0 - r ) / stdlib_base_ln( 1.0 - p ) ) );
5052
}

0 commit comments

Comments
 (0)