Auto-generated commit

Author: stdlib-bot

.github/PULL_REQUEST_TEMPLATE.md

@@ -2,6 +2,6 @@
 
 We are excited about your pull request, but unfortunately we are not accepting pull requests against this repository, as all development happens on the [main project repository](https://github.com/stdlib-js/stdlib). We kindly request that you submit this pull request against the [respective directory](https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/base/dists/triangular/logcdf) of the main repository where we’ll review and provide feedback. 
 
-If this is your first stdlib contribution, be sure to read the [contributing guide](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md) which provides guidelines and instructions for submitting contributions. You may also consult the [development guide](https://github.com/stdlib-js/stdlib/blob/develop/docs/development.md) for help on developing stdlib.
+If this is your first stdlib contribution, be sure to read the [contributing guide](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md) which provides guidelines and instructions for submitting contributions. You may also consult the [development guide](https://github.com/stdlib-js/stdlib/blob/develop/docs/contributing/development.md) for help on developing stdlib.
 
 We look forward to receiving your contribution! :smiley:

CHANGELOG.md

@@ -4,14 +4,37 @@
 
 <section class="release" id="unreleased">
 
-## Unreleased (2025-02-19)
+## Unreleased (2025-03-07)
+
+<section class="features">
+
+### Features
+
+-   [`be656a1`](https://github.com/stdlib-js/stdlib/commit/be656a143216896aa6b1ce0df89646e6a3565ec9) - add C implementation for `stats/base/dists/triangular/logcdf` [(#4326)](https://github.com/stdlib-js/stdlib/pull/4326)
+
+</section>
+
+<!-- /.features -->
+
+<section class="issues">
+
+### Closed Issues
+
+This release closes the following issue:
+
+[#3814](https://github.com/stdlib-js/stdlib/issues/3814)
+
+</section>
+
+<!-- /.issues -->
 
 <section class="commits">
 
 ### Commits
 
 <details>
 
+-   [`be656a1`](https://github.com/stdlib-js/stdlib/commit/be656a143216896aa6b1ce0df89646e6a3565ec9) - **feat:** add C implementation for `stats/base/dists/triangular/logcdf` [(#4326)](https://github.com/stdlib-js/stdlib/pull/4326) _(by Prashant Kumar Yadav, Philipp Burckhardt, stdlib-bot)_
 -   [`c7bfa92`](https://github.com/stdlib-js/stdlib/commit/c7bfa923af0c5346766c90300e0d0a3c2188d438) - **docs:** fix missing ending `section` in various READMEs [(#5292)](https://github.com/stdlib-js/stdlib/pull/5292) _(by Saurabh Singh)_
 
 </details>
@@ -24,8 +47,10 @@
 
 ### Contributors
 
-A total of 1 person contributed to this release. Thank you to this contributor:
+A total of 3 people contributed to this release. Thank you to the following contributors:
 
+-   Philipp Burckhardt
+-   Prashant Kumar Yadav
 -   Saurabh Singh
 
 </section>

CONTRIBUTORS

@@ -4,16 +4,21 @@
 
 Aadish Jain <jain.aadishj@gmail.com>
 Aayush Khanna <aayushiitbhu23@gmail.com>
+Abdelrahman Samir <60700731+abdelrahman04@users.noreply.github.com>
+Abhay Punia <156515195+Hecker165@users.noreply.github.com>
 Abhijit Raut <abhijitmraut8010@gmail.com>
+Abhishek Jain <40913033+abhishekblue@users.noreply.github.com>
 Adarsh Palaskar <adarshpalaskar99@gmail.com>
 Aditya Sapra <adityaework@gmail.com>
 Ahmed Atwa <Ahmedatwa866@yahoo.com>
 Ahmed Kashkoush <ahmedkashkoush464@gmail.com>
 Ahmed Khaled <kahmd1444@gmail.com>
+Aksshay Balasubramanian <119944779+Aksshay88@users.noreply.github.com>
 Aleksandr <112382387+alextes90@users.noreply.github.com>
 Ali Salesi <ali_sal1381@yahoo.com>
 Aman Bhansali <bhansali.1@iitj.ac.in>
 Amit Jimiwal <amitjimiwal45@gmail.com>
+Anshu Kumar <132515490+anxhukumar@users.noreply.github.com>
 Anudeep Sanapala <anudeep0306@gmail.com>
 Athan Reines <kgryte@gmail.com>
 Ayaka <73595362+USERSATOSHI@users.noreply.github.com>
@@ -29,6 +34,7 @@ Debashis Maharana <debashismaharana7854@gmail.com>
 Desh Deepak Kant <118960904+DeshDeepakKant@users.noreply.github.com>
 Dev Goel <135586571+corsairier@users.noreply.github.com>
 Dhruv Arvind Singh <154677013+DhruvArvindSingh@users.noreply.github.com>
+Dhruvil Mehta <68022411+dhruvilmehta@users.noreply.github.com>
 Divyansh Seth <59174836+sethdivyansh@users.noreply.github.com>
 Dominic Lim <46486515+domlimm@users.noreply.github.com>
 Dominik Moritz <domoritz@gmail.com>
@@ -37,14 +43,17 @@ EuniceSim142 <77243938+EuniceSim142@users.noreply.github.com>
 Frank Kovacs <fran70kk@gmail.com>
 GK Bishnoi <gkishan1kyt@gmail.com>
 Gaurav <gaurav70380@gmail.com>
+Gautam sharma <gautamkrishnasharma1@gmail.com>
 Golden Kumar <103646877+AuenKr@users.noreply.github.com>
 Gunj Joshi <gunjjoshi8372@gmail.com>
 Gururaj Gurram <gururajgurram1512@gmail.com>
 Harsh <149176984+hrshya@users.noreply.github.com>
 HarshaNP <96897754+GittyHarsha@users.noreply.github.com>
 Harshita Kalani <harshitakalani02@gmail.com>
+Hemant M Mehta <92446645+hemantmm@users.noreply.github.com>
 Hridyanshu <124202756+HRIDYANSHU054@users.noreply.github.com>
 Jaimin Godhani <112328542+Jai0401@users.noreply.github.com>
+Jalaj Kumar <142599224+jalajk3004@users.noreply.github.com>
 James Gelok <jdgelok@gmail.com>
 Jaysukh Makvana <jaysukhmakvana2004@gmail.com>
 Jenish Thapa <141203631+jenish-thapa@users.noreply.github.com>
@@ -54,9 +63,11 @@ Joey Reed <joeyrreed@gmail.com>
 Jordan Gallivan <115050475+Jordan-Gallivan@users.noreply.github.com>
 Joris Labie <joris.labie1@gmail.com>
 Justin Dennison <justin1dennison@gmail.com>
+Justyn Shelby <96994781+ShelbyJustyn@users.noreply.github.com>
 Karan Anand <119553199+anandkaranubc@users.noreply.github.com>
 Karthik Prakash <116057817+skoriop@users.noreply.github.com>
 Kohantika Nath <145763549+kohantikanath@users.noreply.github.com>
+Krishnam Agarwal <83017176+888krishnam@users.noreply.github.com>
 Krishnendu Das <86651039+itskdhere@users.noreply.github.com>
 Kshitij-Dale <152467202+Kshitij-Dale@users.noreply.github.com>
 Lovelin Dhoni J B <100030865+lovelindhoni@users.noreply.github.com>
@@ -74,6 +85,7 @@ Naresh Jagadeesan <naresh.naresh000@gmail.com>
 Naveen Kumar <stupiddint@gmail.com>
 Neeraj Pathak <neerajrpathak710@gmail.com>
 Nishant Shinde <97207366+nishant-s7@users.noreply.github.com>
+Nishchay Rajput <121144841+NishchayRajput@users.noreply.github.com>
 Nithin Katta <88046362+nithinkatta@users.noreply.github.com>
 Nourhan Hasan <109472010+TheNourhan@users.noreply.github.com>
 Ognjen Jevremović <ognjenjevremovic@users.noreply.github.com>
@@ -94,6 +106,7 @@ Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
 Ricky Reusser <rsreusser@gmail.com>
 Ridam Garg <67867319+RidamGarg@users.noreply.github.com>
 Rishav <115060907+rishav2404@users.noreply.github.com>
+Rishav Tarway <rishavtarway@gmail.com>
 Robert Gislason <gztown2216@yahoo.com>
 Roman Stetsyk <25715951+romanstetsyk@users.noreply.github.com>
 Rutam Kathale <138517416+performant23@users.noreply.github.com>
@@ -117,6 +130,7 @@ Spandan Barve <contact@marsian.dev>
 Stephannie Jiménez Gacha <steff456@hotmail.com>
 Suhaib Ilahi <suhaib.elahi87@gmail.com>
 Suraj Kumar <125961509+kumarsuraj212003@users.noreply.github.com>
+Tanishq Ahuja <68651083+TheGEN1U5@users.noreply.github.com>
 Tirtadwipa Manunggal <tirtadwipa.manunggal@gmail.com>
 Tudor Pagu <104032457+tudor-pagu@users.noreply.github.com>
 Tufailahmed Bargir <142114244+Tufailahmed-Bargir@users.noreply.github.com>
@@ -130,9 +144,13 @@ Vivek Maurya <vm8118134@gmail.com>
 Xiaochuan Ye <tap91624@gmail.com>
 Yaswanth Kosuru <116426380+yaswanthkosuru@users.noreply.github.com>
 Yernar Yergaziyev <yernar.yergaziyev@erg.kz>
+Yugal Kaushik <yugalkaushik14@gmail.com>
 Yuvi Mittal <128018763+yuvi-mittal@users.noreply.github.com>
+ditsu <170345142+ditsus@users.noreply.github.com>
 ekambains <bainsinbusiness@gmail.com>
+fadiothman22 <48636283+fadiothman22@users.noreply.github.com>
 olenkabilonizhka <62379231+olenkabilonizhka@users.noreply.github.com>
 pranav-1720 <123018993+pranav-1720@users.noreply.github.com>
+rahulrangers <127782777+rahulrangers@users.noreply.github.com>
 rainn <88160429+AmCodesLame@users.noreply.github.com>
 rei2hu <reimu@reimu.ws>

README.md

@@ -154,7 +154,7 @@ y = mylogcdf( 8.0 );
 
 ## Notes
 
--   In virtually all cases, using the `logpdf` or `logcdf` functions is preferable to manually computing the logarithm of the `pdf` or `cdf`, respectively, since the latter is prone to overflow and underflow.
+-   In virtually all cases, using the `logcdf` or `logcdf` functions is preferable to manually computing the logarithm of the `pdf` or `cdf`, respectively, since the latter is prone to overflow and underflow.
 
 </section>
 
@@ -191,6 +191,105 @@ for ( i = 0; i < 25; i++ ) {
 
 <!-- /.examples -->
 
+<!-- C interface documentation. -->
+
+* * *
+
+<section class="c">
+
+## C APIs
+
+<!-- Section to include introductory text. Make sure to keep an empty line after the intro `section` element and another before the `/section` close. -->
+
+<section class="intro">
+
+</section>
+
+<!-- /.intro -->
+
+<!-- C usage documentation. -->
+
+<section class="usage">
+
+### Usage
+
+```c
+#include "stdlib/stats/base/dists/geometric/logcdf.h"
+```
+
+#### stdlib_base_dists_geometric_logcdf( x, a, b, c )
+
+Evaluates the natural logarithm of the [cumulative distribution function][cdf] (CDF) for a [triangular][triangular-distribution] distribution with parameters `a` (lower limit), `b` (upper limit) and `c` (mode).
+
+```c
+double y = stdlib_base_dists_geometric_logcdf( 0.5, -1.0, 1.0, 0.0 );
+// returns ~-0.134
+```
+
+The function accepts the following arguments:
+
+-   **x**: `[in] double` input value.
+-   **a**: `[in] double` lower limit.
+-   **b**: `[in] double` upper limit.
+-   **c**: `[in] double` mode.
+
+```c
+double stdlib_base_dists_geometric_logcdf( const double x, const double a, const double b, const double c );
+```
+
+</section>
+
+<!-- /.usage -->
+
+<!-- C API usage notes. Make sure to keep an empty line after the `section` element and another before the `/section` close. -->
+
+<section class="notes">
+
+</section>
+
+<!-- /.notes -->
+
+<!-- C API usage examples. -->
+
+<section class="examples">
+
+### Examples
+
+```c
+#include "stdlib/stats/base/dists/triangular/logcdf.h"
+#include "stdlib/constants/float64/eps.h"
+#include <stdlib.h>
+#include <stdio.h>
+#include <math.h>
+
+static double random_uniform( const double min, const double max ) {
+    double v = (double)rand() / ( (double)RAND_MAX + 1.0 );
+    return min + ( v*(max-min) );
+}
+
+int main( void ) {
+    double a;
+    double b;
+    double c;
+    double x;
+    double y;
+    int i;
+
+    for ( i = 0; i < 25; i++ ) {
+        x = random_uniform( 0.0, 30.0 );
+        a = random_uniform( 0.0, 10.0 );
+        b = random_uniform( a + STDLIB_CONSTANT_FLOAT64_EPS, 40.0 );
+        c = random_uniform( a, b );
+        y = stdlib_base_dists_triangular_logcdf( x, a, b, c );
+        printf( "x: %lf, a: %lf, b: %lf, c: %lf, ln(F(x;a,b,c)): %lf\n", x, a, b, c, y );
+    }
+}
+```
+
+</section>
+
+<!-- /.examples -->
+
 </section>
 
 <!-- /.c -->

benchmark/benchmark.js

@@ -21,8 +21,9 @@
 // MODULES //
 
 var bench = require( '@stdlib/bench-harness' );
-var randu = require( '@stdlib/random-base-randu' );
+var uniform = require( '@stdlib/random-base-uniform' );
 var isnan = require( '@stdlib/math-base-assert-is-nan' );
+var Float64Array = require( '@stdlib/array-float64' );
 var EPS = require( '@stdlib/constants-float64-eps' );
 var pkg = require( './../package.json' ).name;
 var logcdf = require( './../lib' );
@@ -34,17 +35,26 @@ bench( pkg, function benchmark( b ) {
 	var mode;
 	var min;
 	var max;
+	var len;
 	var x;
 	var y;
 	var i;
 
+	len = 100;
+	x = new Float64Array( len );
+	min = new Float64Array( len );
+	max = new Float64Array( len );
+	mode = new Float64Array( len );
+	for ( i = 0; i < len; i++ ) {
+		x[ i ] = uniform( 0.0, 30.0 );
+		min[ i ] = uniform( 0.0, 10.0 );
+		max[ i ] = uniform( min[ i ] + EPS, min[ i ] + 40.0 );
+		mode[ i ] = uniform( min[ i ], max[ i ] );
+	}
+
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		x = randu() * 30.0;
-		min = randu() * 10.0;
-		max = min + ( randu() * 40.0 ) + EPS;
-		mode = min + ( ( max - min ) * randu() );
-		y = logcdf( x, min, max, mode );
+		y = logcdf( x[ i%len ], min[ i%len ], max[ i%len ], mode[ i%len ] );
 		if ( isnan( y ) ) {
 			b.fail( 'should not return NaN' );
 		}
@@ -73,7 +83,7 @@ bench( pkg+':factory', function benchmark( b ) {
 
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		x = ( randu()*2.0 ) - 2.0;
+		x = uniform( -2.0, 2.0 );
 		y = mylogcdf( x );
 		if ( isnan( y ) ) {
 			b.fail( 'should not return NaN' );