Merge file ignoring options

The options are already combined in code as globs.

Author: john-shaffer

src/CoreOptions.php

@@ -254,43 +254,6 @@ public static function optionSpecs(): array {
                 'Crawl Concurrency',
                 'The maximum number of files that will be crawled at the same time.'
             ),
-            self::makeOptionSpec(
-                'array',
-                'fileExtensionsToIgnore',
-                '1',
-                'File Extensions to Ignore',
-                'Files with these extensions will be ignored.',
-                implode(
-                    "\n",
-                    [
-                        '.bat',
-                        '.crt',
-                        '.data', // et-cache puts these in wp-content/et-cache
-                        '.DS_Store',
-                        '.git',
-                        '.idea',
-                        '.ini',
-                        '.less',
-                        '.map',
-                        '.md',
-                        '.mo',
-                        '.php',
-                        '.PHP',
-                        '.phtml',
-                        '.po',
-                        '.pot',
-                        '.scss',
-                        '.sh',
-                        '.sql',
-                        '.SQL',
-                        '.tar.gz',
-                        '.tpl',
-                        '.txt',
-                        '.yarn',
-                        '.zip',
-                    ]
-                )
-            ),
             self::makeOptionSpec(
                 'array',
                 'filenamesToIgnore',
@@ -301,6 +264,31 @@ public static function optionSpecs(): array {
                 implode(
                     "\n",
                     [
+                        '**.bat',
+                        '**.crt',
+                        '**.data', // et-cache puts these in wp-content/et-cache
+                        '**.DS_Store',
+                        '**.git',
+                        '**.idea',
+                        '**.ini',
+                        '**.less',
+                        '**.map',
+                        '**.md',
+                        '**.mo',
+                        '**.php',
+                        '**.PHP',
+                        '**.phtml',
+                        '**.po',
+                        '**.pot',
+                        '**.scss',
+                        '**.sh',
+                        '**.sql',
+                        '**.SQL',
+                        '**.tar.gz',
+                        '**.tpl',
+                        '**.txt',
+                        '**.yarn',
+                        '**.zip',
                         '__MACOSX',
                         '.babelrc',
                         '.git',
@@ -858,17 +846,6 @@ public static function savePosted( string $screen = 'core' ): void {
                     [ 'name' => 'crawlConcurrency' ]
                 );
 
-                $file_extensions_to_ignore = preg_replace(
-                    '/^\s+|\s+$/m',
-                    '',
-                    strval( filter_input( INPUT_POST, 'fileExtensionsToIgnore' ) )
-                );
-                $wpdb->update(
-                    $table_name,
-                    [ 'blob_value' => $file_extensions_to_ignore ],
-                    [ 'name' => 'fileExtensionsToIgnore' ]
-                );
-
                 $filenames_to_ignore = preg_replace(
                     '/^\s+|\s+$/m',
                     '',

src/FileFiltering.php

@@ -30,22 +30,6 @@ public function __construct() {
         foreach ( $filenames_to_ignore as $filename ) {
             $this->patterns_to_ignore[] = new FileIgnorePattern( $filename );
         }
-
-        $file_extensions_to_ignore = CoreOptions::getLineDelimitedBlobValue(
-            'fileExtensionsToIgnore'
-        );
-
-        $file_extensions_to_ignore =
-            apply_filters(
-                Controller::getHookName( 'file_extensions_to_ignore' ),
-                $file_extensions_to_ignore
-            );
-
-        foreach ( $file_extensions_to_ignore as $extension ) {
-            $this->patterns_to_ignore[] = new FileIgnorePattern(
-                "**$extension"
-            );
-        }
     }
 
     /**

views/advanced-options-page.php

@@ -33,7 +33,6 @@
     <table class="widefat striped">
         <tbody>
             <?php echo $row( 'filenamesToIgnore' ); ?>
-            <?php echo $row( 'fileExtensionsToIgnore' ); ?>
             <?php echo $row( 'logDetectionSteps' ); ?>
         </tbody>
     </table>