Rename filenamesToIgnore to pathsToIgnore

Because of URL discovery, we need a path-oriented
filter rather than a file-oriented filter. The
name makes this more clear.

Author: john-shaffer

src/CoreOptions.php

@@ -256,10 +256,10 @@ public static function optionSpecs(): array {
             ),
             self::makeOptionSpec(
                 'array',
-                'filenamesToIgnore',
+                'pathsToIgnore',
                 '1',
-                'Directory and File Names to Ignore',
-                'Directories and files with these names will be ignored.' .
+                'Paths to Ignore',
+                'Path matching these patterns will be ignored.' .
                 ' Glob syntax is supported via <a href="https://github.com/PHLAK/Splat">Splat</a>.',
                 implode(
                     "\n",
@@ -846,15 +846,15 @@ public static function savePosted( string $screen = 'core' ): void {
                     [ 'name' => 'crawlConcurrency' ]
                 );
 
-                $filenames_to_ignore = preg_replace(
+                $paths_to_ignore = preg_replace(
                     '/^\s+|\s+$/m',
                     '',
-                    strval( filter_input( INPUT_POST, 'filenamesToIgnore' ) )
+                    strval( filter_input( INPUT_POST, 'pathsToIgnore' ) )
                 );
                 $wpdb->update(
                     $table_name,
-                    [ 'blob_value' => $filenames_to_ignore ],
-                    [ 'name' => 'filenamesToIgnore' ]
+                    [ 'blob_value' => $paths_to_ignore ],
+                    [ 'name' => 'pathsToIgnore' ]
                 );
 
                 $hosts_to_rewrite = preg_replace(

src/FileFiltering.php

@@ -19,9 +19,9 @@ class FileFiltering {
     public function __construct() {
         $this->patterns_to_ignore = [];
 
-        $filenames_to_ignore = CoreOptions::getLineDelimitedBlobValue( 'filenamesToIgnore' );
+        $paths_to_ignore = CoreOptions::getLineDelimitedBlobValue( 'pathsToIgnore' );
 
-        foreach ( $filenames_to_ignore as $filename ) {
+        foreach ( $paths_to_ignore as $filename ) {
             $this->patterns_to_ignore[] = new FileIgnorePattern( $filename );
         }
     }

tests/unit/FileHelperTest.php

@@ -101,8 +101,8 @@ public function testDeleteDirWithFiles() {
      * @return void
      */
     public function testGetListOfLocalFilesByDir() {
-        $filenames_to_ignore = CoreOptions::getDefaultLineDelimitedBlobValue(
-            'filenamesToIgnore'
+        $paths_to_ignore = CoreOptions::getDefaultLineDelimitedBlobValue(
+            'pathsToIgnore'
         );
         $file_extensions_to_ignore = CoreOptions::getDefaultLineDelimitedBlobValue(
             'fileExtensionsToIgnore'
@@ -147,7 +147,7 @@ public function testGetListOfLocalFilesByDir() {
         ];
         $actual = FilesHelper::getListOfLocalFilesByDir(
             $filepath,
-            $filenames_to_ignore,
+            $paths_to_ignore,
             $file_extensions_to_ignore
         );
         $this->assertEquals( $expected, $actual );
@@ -161,7 +161,7 @@ public function testGetListOfLocalFilesByDir() {
         ];
         $actual = FilesHelper::getListOfLocalFilesByDir(
             $filepath,
-            $filenames_to_ignore,
+            $paths_to_ignore,
             $file_extensions_to_ignore
         );
         $this->assertEquals( $expected, $actual );
@@ -173,7 +173,7 @@ public function testGetListOfLocalFilesByDir() {
         ];
         $actual = FilesHelper::getListOfLocalFilesByDir(
             $filepath,
-            $filenames_to_ignore,
+            $paths_to_ignore,
             $file_extensions_to_ignore
         );
 
@@ -186,20 +186,20 @@ public function testGetListOfLocalFilesByDir() {
      * @return void
      */
     public function testPathLooksCrawlable() {
-        $filenames_to_ignore = CoreOptions::getDefaultLineDelimitedBlobValue(
-            'filenamesToIgnore'
+        $paths_to_ignore = CoreOptions::getDefaultLineDelimitedBlobValue(
+            'pathsToIgnore'
         );
         $file_extensions_to_ignore = CoreOptions::getDefaultLineDelimitedBlobValue(
             'fileExtensionsToIgnore'
         );
 
         $looks_crawlable = function ( $file_name ) use (
-            &$filenames_to_ignore,
+            &$paths_to_ignore,
             &$file_extensions_to_ignore
         ) {
             return FilesHelper::pathLooksCrawlable(
                 $file_name,
-                $filenames_to_ignore,
+                $paths_to_ignore,
                 $file_extensions_to_ignore
             );
         };

views/advanced-options-page.php

@@ -32,7 +32,7 @@
 
     <table class="widefat striped">
         <tbody>
-            <?php echo $row( 'filenamesToIgnore' ); ?>
+            <?php echo $row( 'pathsToIgnore' ); ?>
             <?php echo $row( 'logDetectionSteps' ); ?>
         </tbody>
     </table>