Fix calculation for Content-MD5 in S3 deployer

john-shaffer · john-shaffer · commit 15194b685478 · 2025-07-29T15:33:53.000-05:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,7 @@
 ## Unreleased
 
+- Fix wrong calculation for Content-MD5 in S3 deployer.
+
 ## 9.3.1 (2025-07-29)
 
 - Fix "direct-deploy --no-detect" gave the message
diff --git a/src/S3/Deployer.php b/src/S3/Deployer.php
@@ -164,7 +164,7 @@ public function uploadFilesIter( \Iterator $path_infos ): void {
                         WsLog::l( 'Failed to hash file ' . $filename );
                         continue;
                     } else {
-                        $file_hash = $path_info->getContentHash();
+                        $file_hash = hex2bin( $path_info->getContentHash() );
                         $cmd_data['ContentMD5'] = base64_encode( $file_hash );
                         $cmd_data['ContentType'] = $content_type;
                     }

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ public function uploadFilesIter( \Iterator $path_infos ): void {`
`164`	`164`	`WsLog::l( 'Failed to hash file ' . $filename );`
`165`	`165`	`continue;`
`166`	`166`	`} else {`
`167`		`- $file_hash = $path_info->getContentHash();`
	`167`	`+ $file_hash = hex2bin( $path_info->getContentHash() );`
`168`	`168`	`$cmd_data['ContentMD5'] = base64_encode( $file_hash );`
`169`	`169`	`$cmd_data['ContentType'] = $content_type;`
`170`	`170`	`}`