Drop support for SpecFlow versions below v2.1.0.

Author: stajs

src/SpecFlow.NetCore/Fixer.cs

@@ -1,18 +1,16 @@
 using System;
-using System.Collections.Generic;
 using System.Diagnostics;
 using System.IO;
 using System.Linq;
 using System.Text;
 using System.Xml.Linq;
 using System.Xml.XPath;
+using static System.Console;
 
 namespace SpecFlow.NetCore
 {
 	internal class Fixer
 	{
-		public readonly string SpecFlowExe;
-
 		private const string AppConfigSpecFlowSectionDefinitionType = "TechTalk.SpecFlow.Configuration.ConfigurationSectionHandler, TechTalk.SpecFlow";
 
 		private const string AppConfigSpecFlowSectionDefinition = @"	<configSections>
@@ -26,53 +24,25 @@ internal class Fixer
 		<" + AppConfigSpecFlowSectionElement + @" name=""xUnit"" />
 	</specFlow>";
 
+		private readonly string _specFlowExe;
+
 		public Fixer()
 		{
-			// TODO: Allow for other DNX install locations.
-			var users = Directory.GetDirectories(@"C:\Users");
-
-			var dnxUser = users.SingleOrDefault(u =>
-			{
-				try
-				{
-					return Directory.GetDirectories(u).Any(d => d.Contains(".dnx"));
-				}
-				catch (UnauthorizedAccessException)
-				{
-					return false;
-				}
-			});
-			if (dnxUser == null)
-			{
-				throw new Exception("Can't find a user with a .dnx folder in his/her home directory");
-			}
+			// For full .NET Framework, you can get the user profile with: Environment.GetFolderPath(Environment.SpecialFolder.UserProfile)
+			// This isn't available yet in .NET Core, so rely on the environment variable for now.
+			var userProfile = Environment.GetEnvironmentVariable("USERPROFILE");
 
-			var SpecFlowPaths = new List<string>
-				{
-					 Path.Combine(dnxUser, @".nuget\packages\SpecFlow\2.1.0\tools\specflow.exe"),
-					 Path.Combine(dnxUser, @".dnx\packages\SpecFlow\2.1.0\tools\specflow.exe"),
-					 Path.Combine(dnxUser, @".nuget\packages\SpecFlow\2.0.0\tools\specflow.exe"),
-					 Path.Combine(dnxUser, @".dnx\packages\SpecFlow\2.0.0\tools\specflow.exe"),
-					 Path.Combine(dnxUser, @".nuget\packages\SpecFlow\1.9.0\tools\specflow.exe"),
-					 Path.Combine(dnxUser, @".dnx\packages\SpecFlow\1.9.0\tools\specflow.exe")
-				};
-
-			for (var i = 0; i < SpecFlowPaths.Count && !File.Exists(SpecFlowExe); i++)
-			{
-				SpecFlowExe = SpecFlowPaths[i];
-			}
+			_specFlowExe = Path.Combine(userProfile, @".nuget\packages\SpecFlow\2.1.0\tools\specflow.exe");
 
-			if (!File.Exists(SpecFlowExe))
-			{
-				throw new Exception("Can't find SpecFlow: " + SpecFlowExe);
-			}
+			if (!File.Exists(_specFlowExe))
+				throw new Exception("Can't find SpecFlow: " + _specFlowExe);
 
-			Console.WriteLine("Found: " + SpecFlowExe);
+			WriteLine("Found: " + _specFlowExe);
 		}
 
 		public void Fix(DirectoryInfo directory)
 		{
-			Console.WriteLine("Current directory: " + directory);
+			WriteLine("Current directory: " + directory);
 			var xproj = GetXproj(directory);
 			var fakeCsproj = SaveFakeCsProj(directory, xproj);
 			GenerateSpecFlowGlue(directory, fakeCsproj);
@@ -82,19 +52,19 @@ public void Fix(DirectoryInfo directory)
 
 		private void DeleteFakeCsProj(FileInfo fakeCsproj)
 		{
-			Console.WriteLine("Removing: " + fakeCsproj.FullName);
+			WriteLine("Removing: " + fakeCsproj.FullName);
 			fakeCsproj.Delete();
 		}
 
 		private void FixXunit(DirectoryInfo directory)
 		{
-			Console.WriteLine("Fixing SpecFlow generated files for xUnit 2");
+			WriteLine("Fixing SpecFlow generated files for xUnit 2");
 
 			var glueFiles = directory.GetFiles("*.feature.cs", SearchOption.AllDirectories);
 
 			foreach (var glueFile in glueFiles)
 			{
-				Console.WriteLine("Fixed: " + glueFile.FullName);
+				WriteLine("Fixed: " + glueFile.FullName);
 				var content = File.ReadAllText(glueFile.FullName);
 				content = content.Replace(" : Xunit.IUseFixture<", " : Xunit.IClassFixture<");
 				content = content.Replace("[Xunit.Extensions", "[Xunit");
@@ -107,13 +77,13 @@ private string SaveSpecFlowConfig()
 			// Target later version of .NET.
 			// Credit: http://stackoverflow.com/questions/11363202/specflow-fails-when-trying-to-generate-test-execution-report
 
-			Console.WriteLine("Generating specflow.exe.config.");
+			WriteLine("Generating specflow.exe.config.");
 
-			var configPath = SpecFlowExe + ".config";
+			var configPath = _specFlowExe + ".config";
 			var content = "<?xml version=\"1.0\" encoding=\"utf-8\" ?><configuration><startup><supportedRuntime version=\"v4.0.30319\" /></startup></configuration>";
-			Console.WriteLine(content);
+			WriteLine(content);
 
-			Console.WriteLine("Saving: " + configPath);
+			WriteLine("Saving: " + configPath);
 			File.WriteAllText(configPath, content);
 
 			return configPath;
@@ -126,25 +96,25 @@ private string EnsureAppConfig(DirectoryInfo directory)
 			if (File.Exists(path))
 				return path;
 
-			Console.WriteLine("Generating app.config.");
+			WriteLine("Generating app.config.");
 
 			var content = $@"<?xml version=""1.0"" encoding=""utf-8""?>
 <configuration>
 {AppConfigSpecFlowSectionDefinition}
 {AppConfigSpecFlowSection}
 </configuration>";
 
-			Console.WriteLine(content);
+			WriteLine(content);
 
-			Console.WriteLine("Saving: " + path);
+			WriteLine("Saving: " + path);
 			File.WriteAllText(path, content);
 
 			return path;
 		}
 
 		private void ValidateAppConfig(string path)
 		{
-			Console.WriteLine("Validating app.config.");
+			WriteLine("Validating app.config.");
 
 			// I would rather use the ConfigurationBuilder, but as of beta8 it fails to read an element without
 			// a value, e.g.: <unitTestProvider name="xUnit" />
@@ -169,15 +139,15 @@ private void RunSpecFlow(string csproj)
 		{
 			// Credit: http://www.marcusoft.net/2010/12/specflowexe-and-mstest.html
 			var arguments = $"generateall {csproj} /force /verbose";
-			Console.WriteLine($"Calling: {SpecFlowExe} {arguments}");
+			WriteLine($"Calling: {_specFlowExe} {arguments}");
 
 			var p = new Process
 			{
 				StartInfo =
 					 {
 						  UseShellExecute = false,
 						  RedirectStandardOutput = true,
-						  FileName = SpecFlowExe,
+						  FileName = _specFlowExe,
 						  Arguments = arguments
 					 }
 			};
@@ -187,15 +157,15 @@ private void RunSpecFlow(string csproj)
 			var output = p.StandardOutput.ReadToEnd();
 			p.WaitForExit();
 
-			Console.WriteLine(output);
+			WriteLine(output);
 
 			if (output.Contains("-> test generation failed"))
 				throw new Exception("SpecFlow generation failed (review the output).");
 		}
 
 		private void DeleteSpecFlowConfig(string configPath)
 		{
-			Console.WriteLine("Removing the SpecFlow config file.");
+			WriteLine("Removing the SpecFlow config file.");
 			File.Delete(configPath);
 		}
 
@@ -210,7 +180,7 @@ private void GenerateSpecFlowGlue(DirectoryInfo directory, FileInfo fakeCsproj)
 
 		private FileInfo SaveFakeCsProj(DirectoryInfo directory, FileInfo xproj)
 		{
-			Console.WriteLine("Generating fake csproj.");
+			WriteLine("Generating fake csproj.");
 
 			var featureFiles = directory.GetFiles("*.feature", SearchOption.AllDirectories);
 			var sb = new StringBuilder();
@@ -241,10 +211,10 @@ private FileInfo SaveFakeCsProj(DirectoryInfo directory, FileInfo xproj)
 </Project>");
 
 			var content = sb.ToString();
-			Console.WriteLine(content);
+			WriteLine(content);
 
 			var csprojPath = xproj.FullName + ".fake.csproj";
-			Console.WriteLine("Saving: " + csprojPath);
+			WriteLine("Saving: " + csprojPath);
 			File.WriteAllText(csprojPath, content);
 
 			return new FileInfo(csprojPath);
@@ -261,7 +231,7 @@ private FileInfo GetXproj(DirectoryInfo directory)
 				throw new Exception("More than one '.xproj' found.");
 
 			var xproj = xprojs.Single();
-			Console.WriteLine("Found: " + xproj.FullName);
+			WriteLine("Found: " + xproj.FullName);
 
 			return xproj;
 		}

src/SpecFlow.NetCore/project.json

@@ -1,5 +1,5 @@
 {
-	"version": "1.0.0-rc1",
+	"version": "1.0.0-rc2",
 	"description": "Generate tests from SpecFlow feature files inside ASP.NET Core projects (.xproj's).",
 	"authors": [ "stajs" ],
 
@@ -24,13 +24,5 @@
 
 	"frameworks": {
 		"netcoreapp1.0": {}
-	},
-
-	"backup__________________________________________________________________________": {
-		"runtimes": {
-			"description": "As commented on July 2016, these runtimes are undocumented so backed them up for now and can add them back in once I understand what they are doing. https://docs.microsoft.com/en-us/dotnet/articles/core/tools/project-json#frameworks",
-			"win7-x64": {},
-			"win7-x86": {}
-		}
 	}
 }