Closes #32: Respect NUGET_PACKAGES env var

Also adds argument support for --specflow-path and --working-directory.

Author: stajs

src/SpecFlow.NetCore/AppConfig.cs

@@ -20,6 +20,12 @@ internal class AppConfig
 		public const string SpecFlowSection = @"	<specFlow>
 		<" + SpecFlowSectionElement + @" name=""xUnit"" />
 	</specFlow>";
+
+		public static string Content = $@"<?xml version=""1.0"" encoding=""utf-8""?>
+<configuration>
+{SpecFlowSectionDefinition}
+{SpecFlowSection}
+</configuration>";
 		#endregion
 
 		public string Path { get; }
@@ -37,17 +43,9 @@ public static AppConfig CreateIn(DirectoryInfo directory)
 				return config;
 
 			WriteLine("Generating app.config.");
-
-			// Ignore the strange indentation; it is like that so the final file looks right.
-			var content = $@"<?xml version=""1.0"" encoding=""utf-8""?>
-<configuration>
-{SpecFlowSectionDefinition}
-{SpecFlowSection}
-</configuration>";
-
-			WriteLine(content);
+			WriteLine(Content);
 			WriteLine("Saving: " + config.Path);
-			File.WriteAllText(config.Path, content);
+			File.WriteAllText(config.Path, Content);
 
 			return config;
 		}

src/SpecFlow.NetCore/Args.cs

@@ -0,0 +1,66 @@
+using System;
+using System.IO;
+using System.Linq;
+using static System.Console;
+
+namespace Specflow.NetCore
+{
+	public class Args
+	{
+		public const string SpecFlowPathArgName = "--specflow-path";
+		public const string WorkingDirectoryArgName = "--working-directory";
+
+		public string SpecFlowPath { get; }
+		public DirectoryInfo WorkingDirectory { get; }
+
+		public Args(string[] args)
+		{
+			WorkingDirectory = new DirectoryInfo(Directory.GetCurrentDirectory());
+
+			if (args == null || !args.Any())
+				return;
+
+			// Very basic arg parsing:
+			//   - Assume odd elements are arg names.
+			//   - Assume even elements are arg values.
+			//   - Paths with spaces will probably blow up.
+			//   - Duplicates, last one wins.
+
+			for (var i = 0; i < args.Length; i++)
+			{
+				if (IsOdd(i))
+					continue;
+
+				if (i + 1 >= args.Length)
+					throw new Exception("Uneven arguments");
+
+				var name = args[i];
+				var value = args[i + 1];
+
+				switch (name)
+				{
+					case SpecFlowPathArgName:
+						SpecFlowPath = value;
+						break;
+
+					case WorkingDirectoryArgName:
+						if (!Directory.Exists(value))
+							throw new Exception("Working directory doesn't exist: " + value);
+						WorkingDirectory = new DirectoryInfo(value);
+						break;
+
+					default:
+						throw new Exception("Unknown argument: " + name);
+				}
+			}
+
+			WriteLine("SpecFlowPath: " + SpecFlowPath);
+			WriteLine("WorkingDirectory: " + WorkingDirectory.FullName);
+		}
+
+		private bool IsOdd(int i)
+		{
+			return i % 2 != 0;
+		}
+	}
+}

src/SpecFlow.NetCore/Fixer.cs

@@ -3,6 +3,7 @@
 using System.IO;
 using System.Linq;
 using System.Text;
+using Specflow.NetCore;
 using static System.Console;
 
 namespace SpecFlow.NetCore
@@ -12,23 +13,51 @@ internal class Fixer
 		private readonly string _specFlowExe;
 		private FileInfo[] _featureFiles;
 
-		public Fixer()
+		public Fixer(string specFlowPath = null)
 		{
+			_specFlowExe = FindSpecFlow(specFlowPath);
+			WriteLine("Found: " + _specFlowExe);
+		}
+
+		private string FindSpecFlow(string path)
+		{
+			if (!string.IsNullOrWhiteSpace(path))
+			{
+				if (File.Exists(path))
+					return path;
+
+				throw new Exception("Path to SpecFlow was supplied as an argument, but doesn't exist: " + path);
+			}
+
+			const string relativePathToSpecFlow = @"SpecFlow\2.1.0\tools\specflow.exe";
+
+			var nugetPackagesPath = Environment.GetEnvironmentVariable("NUGET_PACKAGES");
+
+			if (!string.IsNullOrWhiteSpace(nugetPackagesPath))
+			{
+				path = Path.Combine(nugetPackagesPath, relativePathToSpecFlow);
+
+				if (File.Exists(path))
+					return path;
+
+				throw new Exception("NUGET_PACKAGES environment variable found, but SpecFlow doesn't exist: " + path);
+			}
+
 			// For full .NET Framework, you can get the user profile with: Environment.GetFolderPath(Environment.SpecialFolder.UserProfile)
 			// This isn't available yet in .NET Core, so rely on the environment variable for now.
 			var userProfile = Environment.GetEnvironmentVariable("USERPROFILE");
 
-			_specFlowExe = Path.Combine(userProfile, @".nuget\packages\SpecFlow\2.1.0\tools\specflow.exe");
+			path = Path.Combine(userProfile, ".nuget", "packages", relativePathToSpecFlow);
 
-			if (!File.Exists(_specFlowExe))
-				throw new Exception("Can't find SpecFlow: " + _specFlowExe);
+			if (File.Exists(path))
+				return path;
 
-			WriteLine("Found: " + _specFlowExe);
+			throw new Exception($"Can't find SpecFlow: {path}\nTry specifying the path with {Args.SpecFlowPathArgName}.");
 		}
 
 		public void Fix(DirectoryInfo directory)
 		{
-			WriteLine("Current directory: " + directory);
+			WriteLine("Current directory: " + directory.FullName);
 			_featureFiles = directory.GetFiles("*.feature", SearchOption.AllDirectories);
 			var missingGeneratedFiles = _featureFiles.Where(f => !File.Exists(f.FullName + ".cs")).ToList();
 
@@ -103,7 +132,7 @@ private void RunSpecFlow(string csproj)
 		private void GenerateSpecFlowGlue(DirectoryInfo directory, FileInfo fakeCsproj)
 		{
 			AppConfig.CreateIn(directory).Validate();
-			RunSpecFlow(fakeCsproj.Name);
+			RunSpecFlow(fakeCsproj.FullName);
 		}
 
 		private FileInfo SaveFakeCsProj(DirectoryInfo directory, FileInfo xproj)

src/SpecFlow.NetCore/Program.cs

@@ -1,5 +1,5 @@
 using System;
-using System.IO;
+using Specflow.NetCore;
 
 namespace SpecFlow.NetCore
 {
@@ -9,10 +9,9 @@ public static int Main(string[] args)
 		{
 			try
 			{
-				var path = args.Length == 1 ? args[0] : Directory.GetCurrentDirectory();
-				var directory = new DirectoryInfo(path);
-
-				new Fixer().Fix(directory);
+				var a = new Args(args);
+				var fixer = new Fixer(a.SpecFlowPath);
+				fixer.Fix(a.WorkingDirectory);
 
 				PrintUsingColor("SpecFlow fixed.", ConsoleColor.Green);
 				return 0;

src/SpecFlow.NetCore/project.json

@@ -1,5 +1,5 @@
 {
-	"version": "1.0.0-rc4",
+	"version": "1.0.0-rc5",
 	"description": "Generate tests from SpecFlow feature files inside ASP.NET Core projects (.xproj's).",
 	"authors": [ "stajs" ],