Skip to content

Commit 6b3dda3

Browse files
committed
[check-uc*] Create essentially a "no-op" dependency
This works around an unknown aspect of tox in that until you do something (install packages, or run commands) tox doesn't create .tox/{envdir}/log. This isn't a big deal except tox_install_sibling_packages[1] relies on that existing. If it doesn't we end up with a module failure: Change-Id: I3824235b49b77e84e693a8a37c9ff3a1027a3acd --- 2025-10-23 21:38:45.404140 | TASK [tox : Install any sibling python packages] 2025-10-23 21:38:46.846253 | ubuntu-jammy | MODULE FAILURE: <snip> 2025-10-23 21:38:46.847689 | ubuntu-jammy | FileNotFoundError: [Errno 2] No such file or directory: '/home/zuul/src/opendev.org/openstack/requirements/.tox/py310-check-uc/log/py310-check-uc-siblings.txt' --- Until that module is fixed add 'setuptools' as a dependency. It will be installed already as part of the virtualenv so is funtionally equivilent to an empty set of deps. This is a enhancement? to Iaa7f02ec9d1e734884b1329e2b177964f54d64df Also updated upper-constraints.txt to ensure the check-uc* jobs run [1] https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/tox/library/tox_install_sibling_packages.py#L387 Change-Id: I7fd709d0cf0468c90593b5f63bb34d58e9c1e774 Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
1 parent e767f28 commit 6b3dda3

File tree

2 files changed

+19
-4
lines changed

2 files changed

+19
-4
lines changed

tox.ini

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,25 +14,33 @@ commands =
1414
[testenv:py310-check-uc]
1515
basepython = python3.10
1616
skip_install = true
17-
deps =
17+
# For now we need something due to an issue in the tox_install_sibling_packages
18+
# AnseibleModule
19+
deps = setuptools
1820
commands = python -m pip install --dry-run -r{toxinidir}/upper-constraints.txt
1921

2022
[testenv:py311-check-uc]
2123
basepython = python3.11
2224
skip_install = true
23-
deps =
25+
# For now we need something due to an issue in the tox_install_sibling_packages
26+
# AnseibleModule
27+
deps = setuptools
2428
commands = {[testenv:py310-check-uc]commands}
2529

2630
[testenv:py312-check-uc]
2731
basepython = python3.12
2832
skip_install = true
29-
deps =
33+
# For now we need something due to an issue in the tox_install_sibling_packages
34+
# AnseibleModule
35+
deps = setuptools
3036
commands = {[testenv:py310-check-uc]commands}
3137

3238
[testenv:py313-check-uc]
3339
basepython = python3.13
3440
skip_install = true
35-
deps =
41+
# For now we need something due to an issue in the tox_install_sibling_packages
42+
# AnseibleModule
43+
deps = setuptools
3644
commands = {[testenv:py310-check-uc]commands}
3745

3846
[testenv:venv]

upper-constraints.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
# WARNING: OpenStack makes no security guarantees about third-party
2+
# dependencies listed here, and does not keep track of any
3+
# vulnerabilities they contain. Versions of these dependencies are
4+
# frozen at each coordinated release in order to stabilize upstream
5+
# testing, and can contain known vulnerabilities. Consumers are
6+
# *STRONGLY* encouraged to rely on curated distributions of OpenStack
7+
# or manage security patching of dependencies themselves.
18
voluptuous===0.15.2
29
chardet===5.2.0
310
enum-compat===0.0.3

0 commit comments

Comments
 (0)