fix old image discovery

Author: scrungus

examples/templates/old-images.j2

@@ -3,7 +3,7 @@
 # Old magnum images - hide until out of use
 
 {% for item in matching_images %}
-{% if item.value.name not in new_template_data | map(attribute='value.name') | replace('-', '_') %}
+{% if (item.value.name | replace('_', '-')) not in new_template_data | map(attribute='value.name') %}
 {{ item.key }}:
 {% for key, value in item.value.items() %}
 {% if value is mapping %}

examples/templates/old-templates.j2

@@ -3,7 +3,7 @@
 # Old magnum templates - hide until out of use
 
 {% for item in matching_temps %}
-{% if item.key not in new_template_data | map(attribute='key') | replace('-', '_') %}
+{% if (item.key | replace('_', '-')) not in new_template_data | map(attribute='key') %}
 {{ item.key }}:
 {% for key, value in item.value.items() %}
 {% if key == 'is_hidden' %}

examples/templates/templates.j2

@@ -26,7 +26,7 @@
 openstack_container_clusters_templates:
 {% if matching_temps is defined and matching_temps | length > 0 %}
 {% for item in matching_temps %}
-{% if (item.key| replace('_', '-')) not in (new_template_data | map(attribute='key')) %}
+{% if (item.key | replace('_', '-')) not in (new_template_data | map(attribute='key')) %}
   - "{{ '{{ ' + item.key + ' }}' }}"
 {% endif %}
 {% endfor %}