Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 11, 2025

Description

Part of stackabletech/issues#712
Decision: https://github.com/stackabletech/decisions/issues/64
Needs stackabletech/documentation#807 for the documentation part

The actual code change is oversee-able, most of the added lines are tests.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer marked this pull request as ready for review November 20, 2025 15:24
@sbernauer sbernauer self-assigned this Nov 20, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Nov 20, 2025
@sbernauer sbernauer requested a review from a team November 20, 2025 15:24
@Techassi Techassi self-requested a review November 20, 2025 15:30
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly lgtm, a few various question, comments and suggestions.

@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Nov 23, 2025
@sbernauer sbernauer requested a review from Techassi November 23, 2025 16:41
@sbernauer sbernauer requested a review from Techassi November 27, 2025 18:59
@sbernauer sbernauer added this pull request to the merge queue Nov 28, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Nov 28, 2025
Merged via the queue into main with commit b7549cf Nov 28, 2025
8 checks passed
@sbernauer sbernauer deleted the feat/object-overrides branch November 28, 2025 13:38
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Dec 1, 2025
@lfrancke lfrancke moved this from Done to Acceptance: In Progress in Stackable Engineering Dec 1, 2025
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants