Merge pull request #385 from sqlkata/feature/idisposable

implement IDisposable for QueryFactory

Author: ahmad-moussawi

Program/Program.cs

@@ -46,6 +46,13 @@ static void Main(string[] args)
             var compiler = new SqlServerCompiler();
             var sql = compiler.Compile(query).Sql;
             Console.WriteLine(sql);
+
+
+            using (var db = SqlLiteQueryFactory())
+            {
+                var accounts = db.Query("accounts").Get();
+                Console.WriteLine(accounts.Count());
+            }
         }
 
         private static void log(Compiler compiler, Query query)
@@ -79,6 +86,7 @@ private static QueryFactory SqlLiteQueryFactory()
             }
 
             return db;
+
         }
 
         private static QueryFactory SqlServerQueryFactory()

SqlKata.Execution/QueryFactory.cs

@@ -10,11 +10,13 @@
 
 namespace SqlKata.Execution
 {
-    public class QueryFactory
+    public class QueryFactory : IDisposable
     {
         public IDbConnection Connection { get; set; }
         public Compiler Compiler { get; set; }
         public Action<SqlResult> Logger = result => { };
+        private bool disposedValue;
+
         public int QueryTimeout { get; set; } = 30;
 
         public QueryFactory() { }
@@ -823,5 +825,35 @@ internal SqlResult CompileAndLog(Query query)
             return compiled;
         }
 
+        protected virtual void Dispose(bool disposing)
+        {
+            if (!disposedValue)
+            {
+                if (disposing)
+                {
+                    Connection.Dispose();
+                }
+
+                // TODO: free unmanaged resources (unmanaged objects) and override finalizer
+                // TODO: set large fields to null
+                Connection = null;
+                Compiler = null;
+                disposedValue = true;
+            }
+        }
+
+        // // TODO: override finalizer only if 'Dispose(bool disposing)' has code to free unmanaged resources
+        // ~QueryFactory()
+        // {
+        //     // Do not change this code. Put cleanup code in 'Dispose(bool disposing)' method
+        //     Dispose(disposing: false);
+        // }
+
+        public void Dispose()
+        {
+            // Do not change this code. Put cleanup code in 'Dispose(bool disposing)' method
+            Dispose(disposing: true);
+            GC.SuppressFinalize(this);
+        }
     }
 }