Merge pull request #355 from sqlkata/fix/unsafe-literal-fail-on-update

Fix unsafe raw literal on update

Author: ahmad-moussawi

QueryBuilder.Tests/UpdateTests.cs

@@ -194,5 +194,24 @@ public void UpdateFromQueryShouldFail()
 
         }
 
+        [Fact]
+        public void update_should_compile_literal_without_parameters_holders()
+        {
+
+            var query = new Query("MyTable").AsUpdate(new
+            {
+                Name = "The User",
+                Address = new UnsafeLiteral("@address")
+            });
+
+            var compiler = new SqlServerCompiler();
+            var result =  compiler.Compile(query);
+
+            Assert.Equal(
+                "UPDATE [MyTable] SET [Name] = ?, [Address] = @address",
+                result.RawSql
+            );
+        }
+
     }
 }

QueryBuilder/Compilers/Compiler.cs

@@ -291,11 +291,9 @@ private SqlResult CompileUpdateQuery(Query query)
 
             for (var i = 0; i < toUpdate.Columns.Count; i++)
             {
-                parts.Add($"{Wrap(toUpdate.Columns[i])} = ?");
+                parts.Add(Wrap(toUpdate.Columns[i]) + " = " + Parameter(ctx, toUpdate.Values[i]));
             }
 
-            ctx.Bindings.AddRange(toUpdate.Values);
-
             var where = CompileWheres(ctx);
 
             if (!string.IsNullOrEmpty(where))