proto_repository: add attributes to write a proto_repository_info provider (stackb#328)

* Use non-zip archive for @protoapis dep
* Add proto_repository_info provider, rule, and github_proto_repository macro
* Upgrade to rules_go 0.39.1
* Bump minimum bazel version to 5.4.0
* Add test for ProtoRepositoryInfo provider
* Bump bazelci version

Author: pcj

.bazelci/presubmit.yml

@@ -2,7 +2,7 @@
 buildifier:
   version: 5.1.0
   warnings: "-function-docstring,-function-docstring-header,-module-docstring,-function-docstring-args,-list-append"
-bazel: 5.1.1
+bazel: 5.4.0
 tasks:
   default_workspace_ubuntu1804:
     platform: ubuntu1804

.bazelrc

@@ -13,4 +13,3 @@ build:bazelci --deleted_packages=docs
 
 # workaround for scala
 build --incompatible_java_common_parameters=false
-

.bazelversion

@@ -1 +1 @@
-5.1.1
+5.4.0

deps/BUILD.bazel

@@ -97,17 +97,17 @@ depsgen(
     deps = ["//deps:io_grpc_grpc_java"],
 )
 
-# Release: v0.35.0
-# TargetCommitish: release-0.35
-# Date: 2022-09-11 15:59:49 +0000 UTC
-# URL: https://github.com/bazelbuild/rules_go/releases/tag/v0.35.0
-# Size: 931734 (932 kB)
+# Release: v0.39.1
+# TargetCommitish: release-0.39
+# Date: 2023-04-20 04:35:08 +0000 UTC
+# URL: https://github.com/bazelbuild/rules_go/releases/tag/v0.39.1
+# Size: 1759832 (1.8 MB)
 proto_dependency(
     name = "io_bazel_rules_go",
     repository_rule = "http_archive",
-    sha256 = "cc027f11f98aef8bc52c472ced0714994507a16ccd3a0820b2df2d6db695facd",
-    strip_prefix = "rules_go-0.35.0",
-    urls = ["https://github.com/bazelbuild/rules_go/archive/v0.35.0.tar.gz"],
+    sha256 = "473a064d502e89d11c497a59f9717d1846e01515a3210bd169f22323161c076e",
+    strip_prefix = "rules_go-0.39.1",
+    urls = ["https://github.com/bazelbuild/rules_go/archive/v0.39.1.tar.gz"],
     visibility = ["//visibility:public"],
 )
 

deps/core_deps.bzl

@@ -19,10 +19,10 @@ def io_bazel_rules_go():
     _maybe(
         http_archive,
         name = "io_bazel_rules_go",
-        sha256 = "cc027f11f98aef8bc52c472ced0714994507a16ccd3a0820b2df2d6db695facd",
-        strip_prefix = "rules_go-0.35.0",
+        sha256 = "473a064d502e89d11c497a59f9717d1846e01515a3210bd169f22323161c076e",
+        strip_prefix = "rules_go-0.39.1",
         urls = [
-            "https://github.com/bazelbuild/rules_go/archive/v0.35.0.tar.gz",
+            "https://github.com/bazelbuild/rules_go/archive/v0.39.1.tar.gz",
         ],
     )
 

example/golden/BUILD.bazel

@@ -109,6 +109,9 @@ func TestRunGazelle(t *testing.T) {
 	if err := bazel_testing.RunBazel("build", "..."); err != nil {
 		t.Fatal(err)
 	}
+	if err := bazel_testing.RunBazel("test", "..."); err != nil {
+		t.Fatal(err)
+	}
 }
 """,
     strip_prefix = "example/golden/testdata/proto_repository",

example/golden/testdata/proto_repository/BUILD.in

@@ -1,6 +1,7 @@
 
 load("@bazel_gazelle//:def.bzl", "gazelle", "gazelle_binary")
 load("@build_stack_rules_proto//rules:proto_gazelle.bzl", "DEFAULT_LANGUAGES", "proto_gazelle")
+load("//:proto_repository_info_test.bzl", "proto_repository_info_test")
 
 # gazelle:prefix github.com/corp/repo
 # gazelle:go_generate_proto false
@@ -19,4 +20,14 @@ proto_gazelle(
     imports = ["@googleapis//:imports.csv"],
 )
 
+proto_repository_info_test(
+    name = "proto_repository_info_test",
+    info = "@googleapis//:proto_repository",
+    want_source_host = "github.com",
+    want_source_owner = "googleapis",
+    want_source_repo = "googleapis",
+    want_source_commit = "66759bdf6a5ebb898c2a51c8649aefd1ee0b7ffe",
+    want_source_prefix = "",
+)
+
 exports_files(["config.yaml"])

example/golden/testdata/proto_repository/BUILD.out

@@ -1,6 +1,7 @@
 
 load("@bazel_gazelle//:def.bzl", "gazelle_binary")
 load("@build_stack_rules_proto//rules:proto_gazelle.bzl", "DEFAULT_LANGUAGES", "proto_gazelle")
+load("//:proto_repository_info_test.bzl", "proto_repository_info_test")
 
 # gazelle:prefix github.com/corp/repo
 # gazelle:go_generate_proto false
@@ -19,4 +20,14 @@ proto_gazelle(
     imports = ["@googleapis//:imports.csv"],
 )
 
+proto_repository_info_test(
+    name = "proto_repository_info_test",
+    info = "@googleapis//:proto_repository",
+    want_source_commit = "66759bdf6a5ebb898c2a51c8649aefd1ee0b7ffe",
+    want_source_host = "github.com",
+    want_source_owner = "googleapis",
+    want_source_prefix = "",
+    want_source_repo = "googleapis",
+)
+
 exports_files(["config.yaml"])

example/golden/testdata/proto_repository/WORKSPACE

@@ -20,6 +20,9 @@ proto_repository(
     cfgs = ["//:config.yaml"],
     reresolve_known_proto_imports = True,
     sha256 = "b9dbc65ebc738a486265ef7b708e9449bf361541890091983e946557ee0a4bfc",
+    source_commit = "66759bdf6a5ebb898c2a51c8649aefd1ee0b7ffe",
+    source_owner = "googleapis",
+    source_repo = "googleapis",
     strip_prefix = "googleapis-66759bdf6a5ebb898c2a51c8649aefd1ee0b7ffe",
     type = "zip",
     urls = ["https://codeload.github.com/googleapis/googleapis/zip/66759bdf6a5ebb898c2a51c8649aefd1ee0b7ffe"],

example/golden/testdata/proto_repository/proto_repository_info_test.bzl

@@ -0,0 +1,45 @@
+load("@build_stack_rules_proto//rules:providers.bzl", "ProtoRepositoryInfo")
+
+def _proto_repository_info_test_impl(ctx):
+    info = ctx.attr.info[ProtoRepositoryInfo]
+
+    must_attr(info, ctx.attr, "source_host")
+    must_attr(info, ctx.attr, "source_owner")
+    must_attr(info, ctx.attr, "source_repo")
+    must_attr(info, ctx.attr, "source_commit")
+    must_attr(info, ctx.attr, "source_prefix")
+
+    ctx.actions.write(ctx.outputs.json, info.to_json())
+
+    # we're checking attr values in the provider, so the script really does not
+    # need to do anything
+    ctx.actions.write(ctx.outputs.executable, "echo PASS")
+
+    return [DefaultInfo(
+        files = depset([ctx.outputs.json, ctx.outputs.executable]),
+    )]
+
+proto_repository_info_test = rule(
+    implementation = _proto_repository_info_test_impl,
+    attrs = {
+        "info": attr.label(
+            providers = [ProtoRepositoryInfo],
+            mandatory = True,
+        ),
+        "want_source_host": attr.string(),
+        "want_source_owner": attr.string(),
+        "want_source_repo": attr.string(),
+        "want_source_commit": attr.string(),
+        "want_source_prefix": attr.string(),
+    },
+    outputs = {
+        "json": "%{name}.json",
+    },
+    test = True,
+)
+
+def must_attr(info, attr, name):
+    got = getattr(info, name)
+    want = getattr(attr, "want_" + name)
+    if got != want:
+        fail(".%s: want %s, got %s" % (name, want, got))