Refactor exec command and improve code quality

- Refactor ExecFargate for KISS/DRY compliance:
  * Extract helper functions (trySSMParent, tryDirectExecution, etc.)
  * Replace boolean flags with execResult struct
  * Reduce ExecFargate from ~180 lines to ~20 lines
  * Improve error handling and readability

- Fix container name handling in exec command:
  * Add validation when container_name flag is not provided
  * Ensure command is not empty after container name extraction
  * Provide clear error messages for invalid usage

- Remove debug print statement from cmd/run.go

- Fix redundant string wrapping in lib/runFargate.go:
  * Remove unnecessary aws.String()/aws.StringValue() wrapping
  * Use strings directly in log fields

- Add documentation comment about public IP usage in Fargate
  * Note that IPv6 implementation will change this behavior

- Fix linter warnings and improve code consistency

Author: teaguru

cmd/exec.go

@@ -18,14 +18,27 @@ var execCmd = &cobra.Command{
     Args: cobra.MinimumNArgs(1),
     Run: func(cmd *cobra.Command, args []string) {
         viper.SetDefault("run.launch_type", "FARGATE")
-        //var containerName string
+        var containerName string
         var commandArgs []string
         if name := viper.GetString("container_name"); name == "" {
+            // If container_name not provided via flag, use first arg as container name
+            if len(args) < 2 {
+                log.Error("When --container_name is not provided, at least 2 arguments are required: <container_name> <command>")
+                os.Exit(1)
+            }
+            containerName = args[0]
             commandArgs = args[1:]
         } else {
+            containerName = name
             commandArgs = args
         }
 
+        // Validate that we have a command to execute
+        if len(commandArgs) == 0 {
+            log.Error("No command provided to execute")
+            os.Exit(1)
+        }
+
         // Join the commandArgs to form a single command string
         commandString := strings.Join(commandArgs, " ")
 
@@ -35,7 +48,7 @@ var execCmd = &cobra.Command{
             Command:            commandString,
             TaskID:             viper.GetString("task_id"),
             TaskDefinitionName: viper.GetString("task_definition"),
-            ContainerName:      viper.GetString("container_name"),
+            ContainerName:      containerName,
         })
         if err != nil {
             log.WithError(err).Error("Can't execute command in Fargate mode")

cmd/run.go

@@ -7,7 +7,6 @@ import (
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 	"github.com/springload/ecs-tool/lib"
-	"fmt"
 )
 
 var runCmd = &cobra.Command{
@@ -57,5 +56,4 @@ func init() {
 	viper.BindPFlag("log_group", runCmd.PersistentFlags().Lookup("log_group"))
 	viper.BindPFlag("container_name", runCmd.PersistentFlags().Lookup("container_name"))
 	//viper.BindPFlag("task_definition", runCmd.PersistentFlags().Lookup("task_definition"))
-	fmt.Println("Default launch_type set to:", viper.GetString("run.launch_type"))
 }