Skip to content

Commit b16ec9c

Browse files
author
Dave Syer
committed
Ensure global interceptors are added to Servlet
Builds on #42 and #1.
1 parent c6cbfe1 commit b16ec9c

File tree

3 files changed

+16
-3
lines changed

3 files changed

+16
-3
lines changed

samples/grpc-tomcat/pom.xml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,14 @@
6161
<groupId>io.grpc</groupId>
6262
<artifactId>grpc-servlet-jakarta</artifactId>
6363
</dependency>
64+
<dependency>
65+
<groupId>org.springframework.boot</groupId>
66+
<artifactId>spring-boot-starter-actuator</artifactId>
67+
</dependency>
68+
<dependency>
69+
<groupId>io.micrometer</groupId>
70+
<artifactId>micrometer-tracing-bridge-otel</artifactId>
71+
</dependency>
6472

6573
<dependency>
6674
<groupId>org.springframework.boot</groupId>
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
spring.application.name=grpc-tomcat
22
server.port=9090
3-
server.http2.enabled=true
3+
server.http2.enabled=true
4+
logging.pattern.level=%5p [${spring.application.name:},%X{traceId:-},%X{spanId:-}]
5+
management.endpoints.web.exposure.include=*

spring-grpc-spring-boot-autoconfigure/src/main/java/org/springframework/grpc/autoconfigure/server/GrpcServerFactoryAutoConfiguration.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,11 @@
3131
import org.springframework.context.annotation.Configuration;
3232
import org.springframework.context.annotation.Import;
3333
import org.springframework.core.Ordered;
34+
import org.springframework.grpc.server.GrpcServiceDiscoverer;
3435
import org.springframework.util.unit.DataSize;
3536

3637
import io.grpc.BindableService;
38+
import io.grpc.ServerServiceDefinition;
3739
import io.grpc.servlet.jakarta.GrpcServlet;
3840
import io.grpc.servlet.jakarta.ServletServerBuilder;
3941

@@ -67,9 +69,10 @@ static class GrpcServletConfiguration {
6769

6870
@Bean
6971
public ServletRegistrationBean<GrpcServlet> grpcServlet(GrpcServerProperties properties,
70-
List<BindableService> services, ServerBuilderCustomizers serverBuilderCustomizers) {
72+
GrpcServiceDiscoverer discoverer, ServerBuilderCustomizers serverBuilderCustomizers) {
73+
List<ServerServiceDefinition> services = discoverer.findServices();
7174
List<String> paths = services.stream()
72-
.map(service -> "/" + service.bindService().getServiceDescriptor().getName() + "/*")
75+
.map(service -> "/" + service.getServiceDescriptor().getName() + "/*")
7376
.collect(Collectors.toList());
7477
ServletServerBuilder servletServerBuilder = new ServletServerBuilder();
7578
services.forEach(servletServerBuilder::addService);

0 commit comments

Comments
 (0)