Fix order when retrieving job executions with JobExecutionDao

This commit fixes the JDBC DAO. The MongoDB DAO was fixed in
f1cf529

Resolves #5062

Author: fmbenhassine

spring-batch-core/src/main/java/org/springframework/batch/core/repository/dao/jdbc/JdbcJobExecutionDao.java

@@ -144,6 +144,7 @@ SELECT COUNT(*)
 
 	private static final String GET_JOB_EXECUTION_IDS_BY_INSTANCE_ID = """
 			SELECT JOB_EXECUTION_ID FROM %PREFIX%JOB_EXECUTION WHERE JOB_INSTANCE_ID = ?
+			ORDER BY JOB_EXECUTION_ID DESC
 			""";
 
 	JdbcJobInstanceDao jobInstanceDao;
@@ -217,10 +218,10 @@ public List<JobExecution> findJobExecutions(final JobInstance jobInstance) {
 		Assert.notNull(jobInstance, "Job instance cannot be null.");
 		long jobInstanceId = jobInstance.getId();
 		// TODO optimize to a single query with a join if possible
-		List<Long> jobExecutionIds = getJdbcTemplate().queryForList(getQuery(GET_JOB_EXECUTION_IDS_BY_INSTANCE_ID),
-				Long.class, jobInstanceId);
-		List<JobExecution> jobExecutions = new ArrayList<>(jobExecutionIds.size());
-		for (Long jobExecutionId : jobExecutionIds) {
+		List<Long> jobExecutionIdsSortedBackwardByCreationOrder = getJdbcTemplate()
+			.queryForList(getQuery(GET_JOB_EXECUTION_IDS_BY_INSTANCE_ID), Long.class, jobInstanceId);
+		List<JobExecution> jobExecutions = new ArrayList<>(jobExecutionIdsSortedBackwardByCreationOrder.size());
+		for (Long jobExecutionId : jobExecutionIdsSortedBackwardByCreationOrder) {
 			jobExecutions.add(getJobExecution(jobExecutionId));
 		}
 		return jobExecutions;

spring-batch-core/src/test/java/org/springframework/batch/core/repository/dao/jdbc/JdbcJobExecutionDaoTests.java

@@ -19,8 +19,7 @@
 import java.time.LocalDateTime;
 import java.time.LocalTime;
 import java.util.Date;
-
-import javax.transaction.Transactional;
+import java.util.List;
 
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
@@ -155,4 +154,21 @@ void testJobParametersPersistenceRoundTrip() {
 		Assertions.assertEquals(doubleParameter, parameters.getDouble("double"));
 	}
 
+	@Test
+	void testFindJobExecutionsInOrder() {
+		// given
+		JobParameters jobParameters = new JobParametersBuilder().addString("name", "foo").toJobParameters();
+		JobInstance jobInstance = jdbcJobInstanceDao.createJobInstance("job", jobParameters);
+		JobExecution jobExecution1 = jdbcJobExecutionDao.createJobExecution(jobInstance, jobParameters);
+		JobExecution jobExecution2 = jdbcJobExecutionDao.createJobExecution(jobInstance, jobParameters);
+
+		// when
+		List<JobExecution> jobExecutions = jdbcJobExecutionDao.findJobExecutions(jobInstance);
+
+		// then
+		Assertions.assertEquals(2, jobExecutions.size());
+		Assertions.assertEquals(jobExecution2.getId(), jobExecutions.get(0).getId());
+		Assertions.assertEquals(jobExecution1.getId(), jobExecutions.get(1).getId());
+	}
+
 }