Skip to content

Commit f9954d7

Browse files
Keuklarolegz
authored andcommitted
style: code simplification
Resolves #1129
1 parent 7969d06 commit f9954d7

File tree

4 files changed

+12
-18
lines changed

4 files changed

+12
-18
lines changed

spring-cloud-function-adapters/spring-cloud-function-adapter-gcp/src/test/java/org/springframework/cloud/function/adapter/gcp/integration/LocalServerTestSupport.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,10 @@ static ServerProcess startServer(Class<?> springApplicationMainClass, String fun
8888
File javaHome = new File(System.getProperty("java.home"));
8989
assertThat(javaHome.exists()).isTrue();
9090
File javaBin = new File(javaHome, "bin");
91-
File javaCommand = new File(javaBin, "java");
91+
File javaCommand = new File(javaBin, "java.exe");
92+
if (!javaCommand.exists()) {
93+
javaCommand = new File(javaBin, "java");
94+
}
9295
assertThat(javaCommand.exists()).isTrue();
9396
String myClassPath = System.getProperty("java.class.path");
9497
assertThat(myClassPath).isNotNull();

spring-cloud-function-context/src/main/java/org/springframework/cloud/function/context/config/JsonMessageConverter.java

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,7 @@ protected boolean supports(Class<?> clazz) {
6464

6565
@Override
6666
protected boolean canConvertTo(Object payload, @Nullable MessageHeaders headers) {
67-
if (!supportsMimeType(headers)) {
68-
return false;
69-
}
70-
return true;
67+
return supportsMimeType(headers);
7168
}
7269

7370
@Override
@@ -78,10 +75,7 @@ protected boolean canConvertFrom(Message<?> message, @Nullable Class<?> targetCl
7875
private boolean canDiscoverConvertToType(Message<?> message, Class<?> targetClass) {
7976
if (targetClass == null || targetClass == Object.class) {
8077
MimeType mimeType = getMimeType(message.getHeaders());
81-
if (mimeType != null && StringUtils.hasText(mimeType.getParameter("type"))) {
82-
return true;
83-
}
84-
return false;
78+
return mimeType != null && StringUtils.hasText(mimeType.getParameter("type"));
8579
}
8680
return true;
8781
}
@@ -123,13 +117,7 @@ else if (logger.isDebugEnabled()) {
123117
if (payload instanceof byte[]) {
124118
payload = new String((byte[]) payload, StandardCharsets.UTF_8);
125119
}
126-
127-
if (logger.isDebugEnabled()) {
128-
logger.debug("Failed to convert value: " + payload + " to: " + targetClass, e);
129-
}
130-
else {
131-
logger.warn("Failed to convert value: " + payload + " to: " + targetClass);
132-
}
120+
logger.debug("Failed to convert value: " + payload + " to: " + targetClass, e);
133121
}
134122
}
135123
}

spring-cloud-function-samples/function-sample-gcp-http/src/test/java/com/example/LocalServerTestSupport.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,10 @@ private static String getJavaCommand() {
113113
assertThat(javaHome.exists()).isTrue();
114114

115115
File javaBin = new File(javaHome, "bin");
116-
File javaCommand = new File(javaBin, "java");
116+
File javaCommand = new File(javaBin, "java.exe");
117+
if (!javaCommand.exists()) {
118+
javaCommand = new File(javaBin, "java");
119+
}
117120
assertThat(javaCommand.exists()).isTrue();
118121

119122
return javaCommand.toString();

spring-cloud-function-samples/function-sample-kotlin-web/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
<dependency>
3232
<groupId>org.springframework.cloud</groupId>
3333
<artifactId>spring-cloud-function-kotlin</artifactId>
34-
<version>4.1.0-SNAPSHOT</version>
34+
<version>4.1.1-SNAPSHOT</version>
3535
</dependency>
3636
<dependency>
3737
<groupId>org.springframework.cloud</groupId>

0 commit comments

Comments
 (0)