You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Turns out you do need to actually ask for the email of the apple user, and I had just not realized this because once a users grants it, even if it's not asked for in scopes in the future, it'll keep sending it
Copy file name to clipboardExpand all lines: web/src/oauth.ts
+3-6Lines changed: 3 additions & 6 deletions
Original file line number
Diff line number
Diff line change
@@ -168,12 +168,10 @@ export default class OAuthClient {
168
168
switch(provider){
169
169
case'apple':
170
170
/**
171
-
* no matter what you put here, you don't get anything back in the initial response, even though
171
+
* no matter what you put here, you don't get name back in the initial response, even though
172
172
* the apple documentation says it'll send back a 'user' object with the email and name (https://developer.apple.com/documentation/sign_in_with_apple/sign_in_with_apple_js/incorporating_sign_in_with_apple_into_other_platforms/#3332115).
173
-
* additionally, no matter what you put here, you still get the email in the ID token.
174
173
*/
175
-
scope=''
176
-
// scope = 'name email'
174
+
scope='name email'
177
175
break
178
176
case'github':
179
177
scope='read:user user:email'
@@ -191,8 +189,7 @@ export default class OAuthClient {
0 commit comments