Skip to content

Commit f80b48d

Browse files
committed
dw - update client logs and func comments
1 parent a4fcf11 commit f80b48d

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

splitio/client/client.py

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ def _make_evaluation(self, key, feature, attributes, method_name, metric_name):
116116
self._record_stats([(impression, attributes)], start, metric_name, method_name)
117117
return result['treatment'], result['configurations']
118118
except Exception as e: # pylint: disable=broad-except
119-
_LOGGER.error('Error getting treatment for feature')
119+
_LOGGER.error('Error getting treatment for feature flag')
120120
_LOGGER.error(str(e))
121121
_LOGGER.debug('Error: ', exc_info=True)
122122
self._telemetry_evaluation_producer.record_exception(metric_name)
@@ -185,7 +185,7 @@ def _make_evaluations(self, key, features, attributes, method_name, metric_name)
185185

186186
except Exception: # pylint: disable=broad-except
187187
_LOGGER.error('%s: An exception occured when evaluating '
188-
'feature %s returning CONTROL.' % (method_name, feature))
188+
'feature flag %s returning CONTROL.' % (method_name, feature))
189189
treatments[feature] = CONTROL, None
190190
_LOGGER.debug('Error: ', exc_info=True)
191191
continue
@@ -208,7 +208,7 @@ def _make_evaluations(self, key, features, attributes, method_name, metric_name)
208208
return treatments
209209
except Exception: # pylint: disable=broad-except
210210
self._telemetry_evaluation_producer.record_exception(metric_name)
211-
_LOGGER.error('Error getting treatment for features')
211+
_LOGGER.error('Error getting treatment for feature flagss')
212212
_LOGGER.debug('Error: ', exc_info=True)
213213
return input_validator.generate_control_treatments(list(features), method_name)
214214

@@ -233,37 +233,37 @@ def _evaluate_features_if_ready(self, matching_key, bucketing_key, features, att
233233

234234
def get_treatment_with_config(self, key, feature, attributes=None):
235235
"""
236-
Get the treatment and config for a feature and key, with optional dictionary of attributes.
236+
Get the treatment and config for a feature flag and key, with optional dictionary of attributes.
237237
238238
This method never raises an exception. If there's a problem, the appropriate log message
239239
will be generated and the method will return the CONTROL treatment.
240240
241241
:param key: The key for which to get the treatment
242242
:type key: str
243-
:param feature: The name of the feature for which to get the treatment
243+
:param feature: The name of the feature flag for which to get the treatment
244244
:type feature: str
245245
:param attributes: An optional dictionary of attributes
246246
:type attributes: dict
247-
:return: The treatment for the key and feature
247+
:return: The treatment for the key and feature flag
248248
:rtype: tuple(str, str)
249249
"""
250250
return self._make_evaluation(key, feature, attributes, 'get_treatment_with_config',
251251
MethodExceptionsAndLatencies.TREATMENT_WITH_CONFIG)
252252

253253
def get_treatment(self, key, feature, attributes=None):
254254
"""
255-
Get the treatment for a feature and key, with an optional dictionary of attributes.
255+
Get the treatment for a feature flag and key, with an optional dictionary of attributes.
256256
257257
This method never raises an exception. If there's a problem, the appropriate log message
258258
will be generated and the method will return the CONTROL treatment.
259259
260260
:param key: The key for which to get the treatment
261261
:type key: str
262-
:param feature: The name of the feature for which to get the treatment
262+
:param feature: The name of the feature flag for which to get the treatment
263263
:type feature: str
264264
:param attributes: An optional dictionary of attributes
265265
:type attributes: dict
266-
:return: The treatment for the key and feature
266+
:return: The treatment for the key and feature flag
267267
:rtype: str
268268
"""
269269
treatment, _ = self._make_evaluation(key, feature, attributes, 'get_treatment',
@@ -272,37 +272,37 @@ def get_treatment(self, key, feature, attributes=None):
272272

273273
def get_treatments_with_config(self, key, features, attributes=None):
274274
"""
275-
Evaluate multiple features and return a dict with feature -> (treatment, config).
275+
Evaluate multiple feature flags and return a dict with feature flag -> (treatment, config).
276276
277-
Get the treatments for a list of features considering a key, with an optional dictionary of
277+
Get the treatments for a list of feature flags considering a key, with an optional dictionary of
278278
attributes. This method never raises an exception. If there's a problem, the appropriate
279279
log message will be generated and the method will return the CONTROL treatment.
280280
:param key: The key for which to get the treatment
281281
:type key: str
282-
:param features: Array of the names of the features for which to get the treatment
282+
:param features: Array of the names of the feature flags for which to get the treatment
283283
:type feature: list
284284
:param attributes: An optional dictionary of attributes
285285
:type attributes: dict
286-
:return: Dictionary with the result of all the features provided
286+
:return: Dictionary with the result of all the feature flags provided
287287
:rtype: dict
288288
"""
289289
return self._make_evaluations(key, features, attributes, 'get_treatments_with_config',
290290
MethodExceptionsAndLatencies.TREATMENTS_WITH_CONFIG)
291291

292292
def get_treatments(self, key, features, attributes=None):
293293
"""
294-
Evaluate multiple features and return a dictionary with all the feature/treatments.
294+
Evaluate multiple feature flags and return a dictionary with all the feature flag/treatments.
295295
296-
Get the treatments for a list of features considering a key, with an optional dictionary of
296+
Get the treatments for a list of feature flags considering a key, with an optional dictionary of
297297
attributes. This method never raises an exception. If there's a problem, the appropriate
298298
log message will be generated and the method will return the CONTROL treatment.
299299
:param key: The key for which to get the treatment
300300
:type key: str
301-
:param features: Array of the names of the features for which to get the treatment
301+
:param features: Array of the names of the feature flags for which to get the treatment
302302
:type feature: list
303303
:param attributes: An optional dictionary of attributes
304304
:type attributes: dict
305-
:return: Dictionary with the result of all the features provided
305+
:return: Dictionary with the result of all the feature flags provided
306306
:rtype: dict
307307
"""
308308
with_config = self._make_evaluations(key, features, attributes, 'get_treatments',

0 commit comments

Comments
 (0)