Skip to content

Commit e153509

Browse files
committed
polish
1 parent 8281dec commit e153509

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

splitio/models/grammar/matchers/prerequisites.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@ def match(self, key, attributes=None, context=None):
2828
if self._prerequisites == None:
2929
return True
3030

31-
if not isinstance(key, str):
32-
return False
33-
3431
evaluator = context.get('evaluator')
3532
bucketing_key = context.get('bucketing_key')
3633
for prerequisite in self._prerequisites:

tests/models/grammar/test_matchers.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1166,9 +1166,4 @@ def test_matcher_behaviour(self, mocker):
11661166
assert parsed.match('SPLIT_2', {}, {'evaluator': evaluator, 'ec': [{'flags': ['prereq_chain'], 'segment_memberships': {}}]}) is True
11671167

11681168
evaluator.eval_with_context.return_value = {'treatment': 'off'}
1169-
assert parsed.match('SPLIT_2', {}, {'evaluator': evaluator, 'ec': [{'flags': ['prereq_chain'], 'segment_memberships': {}}]}) is False
1170-
1171-
assert parsed.match([], {}, {'evaluator': evaluator, 'ec': [{'flags': ['prereq_chain'], 'segment_memberships': {}}]}) is False
1172-
assert parsed.match({}, {}, {'evaluator': evaluator, 'ec': [{'flags': ['prereq_chain'], 'segment_memberships': {}}]}) is False
1173-
assert parsed.match(123, {}, {'evaluator': evaluator, 'ec': [{'flags': ['prereq_chain'], 'segment_memberships': {}}]}) is False
1174-
assert parsed.match(object(), {}, {'evaluator': evaluator, 'ec': [{'flags': ['prereq_chain'], 'segment_memberships': {}}]}) is False
1169+
assert parsed.match('SPLIT_2', {}, {'evaluator': evaluator, 'ec': [{'flags': ['prereq_chain'], 'segment_memberships': {}}]}) is False

0 commit comments

Comments
 (0)