Skip to content

Commit df31efc

Browse files
committed
removed deprecated setDaemon method
1 parent f0480fb commit df31efc

File tree

10 files changed

+20
-20
lines changed

10 files changed

+20
-20
lines changed

splitio/client/factory.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ def _start_status_updater(self):
136136
# add a listener that updates the status to READY once the flag is set.
137137
ready_updater = threading.Thread(target=self._update_status_when_ready,
138138
name='SDKReadyFlagUpdater')
139-
ready_updater.setDaemon(True)
139+
ready_updater.daemon = True
140140
ready_updater.start()
141141
else:
142142
self._status = Status.READY
@@ -226,7 +226,7 @@ def _wait_for_tasks_to_stop():
226226
destroyed_event.set()
227227

228228
wait_thread = threading.Thread(target=_wait_for_tasks_to_stop)
229-
wait_thread.setDaemon(True)
229+
wait_thread.daemon = True
230230
wait_thread.start()
231231
else:
232232
self._sync_manager.stop(False)
@@ -273,7 +273,7 @@ def resume(self):
273273
target=self._sync_manager.start,
274274
name="SDKInitializer",
275275
)
276-
initialization_thread.setDaemon(True)
276+
initialization_thread.daemon = True
277277
initialization_thread.start()
278278
self._preforked_initialization = False # reset for status updater
279279
self._start_status_updater()
@@ -386,7 +386,7 @@ def _build_in_memory_factory(api_key, cfg, sdk_url=None, events_url=None, # pyl
386386
recorder, manager, preforked_initialization=preforked_initialization)
387387

388388
initialization_thread = threading.Thread(target=manager.start, name="SDKInitializer")
389-
initialization_thread.setDaemon(True)
389+
initialization_thread.daemon = True
390390
initialization_thread.start()
391391

392392
return SplitFactory(api_key, storages, cfg['labelsEnabled'],
@@ -441,7 +441,7 @@ def _build_redis_factory(api_key, cfg):
441441

442442
manager = RedisManager(synchronizer)
443443
initialization_thread = threading.Thread(target=manager.start, name="SDKInitializer")
444-
initialization_thread.setDaemon(True)
444+
initialization_thread.daemon = True
445445
initialization_thread.start()
446446

447447
return SplitFactory(

splitio/push/segmentworker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def start(self):
5555

5656
_LOGGER.debug('Starting Segment Worker')
5757
self._worker = threading.Thread(target=self._run, name='PushSegmentWorker')
58-
self._worker.setDaemon(True)
58+
self._worker.daemon = True
5959
self._worker.start()
6060

6161
def stop(self):

splitio/push/splitsse.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ def connect(url):
135135

136136
url = self._build_url(token)
137137
task = threading.Thread(target=connect, name='SSEConnection', args=(url,))
138-
task.setDaemon(True)
138+
task.daemon = True
139139
task.start()
140140
event_group.wait()
141141
return self._status == SplitSSEClient._Status.CONNECTED

splitio/push/splitworker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ def start(self):
5454

5555
_LOGGER.debug('Starting Split Worker')
5656
self._worker = threading.Thread(target=self._run, name='PushSplitWorker')
57-
self._worker.setDaemon(True)
57+
self._worker.daemon = True
5858
self._worker.start()
5959

6060
def stop(self):

splitio/sync/manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def __init__(self, ready_flag, synchronizer, auth_api, streaming_enabled, sdk_me
5252
self._push = PushManager(auth_api, synchronizer, self._queue, sdk_metadata, sse_url, client_key)
5353
self._push_status_handler = Thread(target=self._streaming_feedback_handler,
5454
name='PushStatusHandler')
55-
self._push_status_handler.setDaemon(True)
55+
self._push_status_handler.daemon = True
5656

5757
def recreate(self):
5858
"""Recreate poolers for forked processes."""

splitio/tasks/util/asynctask.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def start(self):
129129
# Start execution
130130
self._thread = threading.Thread(target=self._execution_wrapper,
131131
name='AsyncTask::' + getattr(self._main, '__name__', 'N/S'))
132-
self._thread.setDaemon(True)
132+
self._thread.daemon = True
133133
try:
134134
self._thread.start()
135135

splitio/tasks/util/workerpool.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def __init__(self, worker_count, worker_func):
2727
for i in range(0, worker_count)
2828
]
2929
for thread in self._threads:
30-
thread.setDaemon(True)
30+
thread.daemon = True
3131

3232
def start(self):
3333
"""Start the workers."""
@@ -117,7 +117,7 @@ def wait_for_completion(self):
117117
def stop(self, event=None):
118118
"""Stop all worker nodes."""
119119
async_stop = Thread(target=self._wait_workers_shutdown, args=(event,))
120-
async_stop.setDaemon(True)
120+
async_stop.daemon = True
121121
async_stop.start()
122122

123123
def _wait_workers_shutdown(self, event):

tests/helpers/mockserver.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def __init__(self, req_queue=None):
2424
self._server = HTTPServer(('localhost', 0),
2525
lambda *xs: SSEHandler(self._queue, *xs, req_queue=req_queue))
2626
self._server_thread = threading.Thread(target=self._blocking_run)
27-
self._server_thread.setDaemon(True)
27+
self._server_thread.daemon = True
2828
self._done_event = threading.Event()
2929

3030
def _blocking_run(self):
@@ -117,7 +117,7 @@ def __init__(self, split_changes=None, segment_changes=None, req_queue=None,
117117
req_queue=req_queue,
118118
auth_response=auth_response))
119119
self._server_thread = threading.Thread(target=self._blocking_run, name="SplitMockServer")
120-
self._server_thread.setDaemon(True)
120+
self._server_thread.daemon = True
121121
self._done_event = threading.Event()
122122

123123
def _blocking_run(self):

tests/push/test_manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ def test_connection_success(self, mocker):
3939
def new_start(*args, **kwargs): # pylint: disable=unused-argument
4040
"""splitsse.start mock."""
4141
thread = Thread(target=manager._handle_connection_ready)
42-
thread.setDaemon(True)
42+
thread.daemon = True
4343
thread.start()
4444
return True
4545

@@ -72,7 +72,7 @@ def test_connection_failure(self, mocker):
7272
def new_start(*args, **kwargs): # pylint: disable=unused-argument
7373
"""splitsse.start mock."""
7474
thread = Thread(target=manager._handle_connection_end)
75-
thread.setDaemon(True)
75+
thread.daemon = True
7676
thread.start()
7777
return False
7878

tests/push/test_sse.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def runner():
2626
"""SSE client runner thread."""
2727
assert client.start('http://127.0.0.1:' + str(server.port()))
2828
client_task = threading.Thread(target=runner)
29-
client_task.setDaemon(True)
29+
client_task.daemon = True
3030
client_task.setName('client')
3131
client_task.start()
3232
with pytest.raises(RuntimeError):
@@ -67,7 +67,7 @@ def runner():
6767
"""SSE client runner thread."""
6868
assert client.start('http://127.0.0.1:' + str(server.port()))
6969
client_task = threading.Thread(target=runner)
70-
client_task.setDaemon(True)
70+
client_task.daemon = True
7171
client_task.setName('client')
7272
client_task.start()
7373

@@ -93,7 +93,7 @@ def test_sse_server_disconnects_abruptly(self):
9393
"""Test correct initialization. Server ends connection."""
9494
server = SSEMockServer()
9595
server.start()
96-
96+
9797
events = []
9898
def callback(event):
9999
"""Callback."""
@@ -105,7 +105,7 @@ def runner():
105105
"""SSE client runner thread."""
106106
assert client.start('http://127.0.0.1:' + str(server.port()))
107107
client_task = threading.Thread(target=runner)
108-
client_task.setDaemon(True)
108+
client_task.daemon = True
109109
client_task.setName('client')
110110
client_task.start()
111111

0 commit comments

Comments
 (0)