added pluggable tests

Author: chillaq

splitio/storage/pluggable.py

@@ -17,7 +17,7 @@
 class PluggableSplitStorageBase(SplitStorage):
     """InMemory implementation of a feature flag storage."""
 
-    _FEATURE_FLAG_NAME_LENGTH = 12
+    _FEATURE_FLAG_NAME_LENGTH = 19
 
     def __init__(self, pluggable_adapter, prefix=None, config_flag_sets=[]):
         """

tests/storage/test_pluggable.py

@@ -255,9 +255,9 @@ def test_init(self):
                 prefix = 'myprefix.'
             else:
                 prefix = ''
-        assert(pluggable_split_storage._prefix == prefix + "SPLITIO.split.{split_name}")
+        assert(pluggable_split_storage._prefix == prefix + "SPLITIO.split.{feature_flag_name}")
         assert(pluggable_split_storage._traffic_type_prefix == prefix + "SPLITIO.trafficType.{traffic_type_name}")
-        assert(pluggable_split_storage._split_till_prefix == prefix + "SPLITIO.splits.till")
+        assert(pluggable_split_storage._feature_flag_till_prefix == prefix + "SPLITIO.splits.till")
 
     # TODO: To be added when producer mode is aupported
 #    def test_put_many(self):
@@ -282,7 +282,7 @@ def test_get(self):
             split1 = splits.from_raw(splits_json['splitChange1_2']['splits'][0])
             split_name = splits_json['splitChange1_2']['splits'][0]['name']
 
-            self.mock_adapter.set(pluggable_split_storage._prefix.format(split_name=split_name), split1.to_json())
+            self.mock_adapter.set(pluggable_split_storage._prefix.format(feature_flag_name=split_name), split1.to_json())
             assert(pluggable_split_storage.get(split_name).to_json() ==  splits.from_raw(splits_json['splitChange1_2']['splits'][0]).to_json())
             assert(pluggable_split_storage.get('not_existing') == None)
 
@@ -295,8 +295,8 @@ def test_fetch_many(self):
             split2_temp['name'] = 'another_split'
             split2 = splits.from_raw(split2_temp)
 
-            self.mock_adapter.set(pluggable_split_storage._prefix.format(split_name=split1.name), split1.to_json())
-            self.mock_adapter.set(pluggable_split_storage._prefix.format(split_name=split2.name), split2.to_json())
+            self.mock_adapter.set(pluggable_split_storage._prefix.format(feature_flag_name=split1.name), split1.to_json())
+            self.mock_adapter.set(pluggable_split_storage._prefix.format(feature_flag_name=split2.name), split2.to_json())
             fetched = pluggable_split_storage.fetch_many([split1.name, split2.name])
             assert(fetched[split1.name].to_json() == split1.to_json())
             assert(fetched[split2.name].to_json() == split2.to_json())
@@ -334,8 +334,8 @@ def test_get_split_names(self):
             split2_temp = splits_json['splitChange1_2']['splits'][0].copy()
             split2_temp['name'] = 'another_split'
             split2 = splits.from_raw(split2_temp)
-            self.mock_adapter.set(pluggable_split_storage._prefix.format(split_name=split1.name), split1.to_json())
-            self.mock_adapter.set(pluggable_split_storage._prefix.format(split_name=split2.name), split2.to_json())
+            self.mock_adapter.set(pluggable_split_storage._prefix.format(feature_flag_name=split1.name), split1.to_json())
+            self.mock_adapter.set(pluggable_split_storage._prefix.format(feature_flag_name=split2.name), split2.to_json())
             assert(pluggable_split_storage.get_split_names() == [split1.name, split2.name])
 
     def test_get_all(self):
@@ -347,8 +347,8 @@ def test_get_all(self):
             split2_temp['name'] = 'another_split'
             split2 = splits.from_raw(split2_temp)
 
-            self.mock_adapter.set(pluggable_split_storage._prefix.format(split_name=split1.name), split1.to_json())
-            self.mock_adapter.set(pluggable_split_storage._prefix.format(split_name=split2.name), split2.to_json())
+            self.mock_adapter.set(pluggable_split_storage._prefix.format(feature_flag_name=split1.name), split1.to_json())
+            self.mock_adapter.set(pluggable_split_storage._prefix.format(feature_flag_name=split2.name), split2.to_json())
             all_splits = pluggable_split_storage.get_all()
             assert([all_splits[0].to_json(), all_splits[1].to_json()] == [split1.to_json(), split2.to_json()])
 
@@ -419,9 +419,9 @@ def test_init(self):
                 prefix = 'myprefix.'
             else:
                 prefix = ''
-        assert(pluggable_split_storage._prefix == prefix + "SPLITIO.split.{split_name}")
+        assert(pluggable_split_storage._prefix == prefix + "SPLITIO.split.{feature_flag_name}")
         assert(pluggable_split_storage._traffic_type_prefix == prefix + "SPLITIO.trafficType.{traffic_type_name}")
-        assert(pluggable_split_storage._split_till_prefix == prefix + "SPLITIO.splits.till")
+        assert(pluggable_split_storage._feature_flag_till_prefix == prefix + "SPLITIO.splits.till")
 
     @pytest.mark.asyncio
     async def test_get(self):
@@ -432,7 +432,7 @@ async def test_get(self):
             split1 = splits.from_raw(splits_json['splitChange1_2']['splits'][0])
             split_name = splits_json['splitChange1_2']['splits'][0]['name']
 
-            await self.mock_adapter.set(pluggable_split_storage._prefix.format(split_name=split_name), split1.to_json())
+            await self.mock_adapter.set(pluggable_split_storage._prefix.format(feature_flag_name=split_name), split1.to_json())
             split = await pluggable_split_storage.get(split_name)
             assert(split.to_json() ==  splits.from_raw(splits_json['splitChange1_2']['splits'][0]).to_json())
             assert(await pluggable_split_storage.get('not_existing') == None)
@@ -447,8 +447,8 @@ async def test_fetch_many(self):
             split2_temp['name'] = 'another_split'
             split2 = splits.from_raw(split2_temp)
 
-            await self.mock_adapter.set(pluggable_split_storage._prefix.format(split_name=split1.name), split1.to_json())
-            await self.mock_adapter.set(pluggable_split_storage._prefix.format(split_name=split2.name), split2.to_json())
+            await self.mock_adapter.set(pluggable_split_storage._prefix.format(feature_flag_name=split1.name), split1.to_json())
+            await self.mock_adapter.set(pluggable_split_storage._prefix.format(feature_flag_name=split2.name), split2.to_json())
             fetched = await pluggable_split_storage.fetch_many([split1.name, split2.name])
             assert(fetched[split1.name].to_json() == split1.to_json())
             assert(fetched[split2.name].to_json() == split2.to_json())
@@ -474,8 +474,8 @@ async def test_get_split_names(self):
             split2_temp = splits_json['splitChange1_2']['splits'][0].copy()
             split2_temp['name'] = 'another_split'
             split2 = splits.from_raw(split2_temp)
-            await self.mock_adapter.set(pluggable_split_storage._prefix.format(split_name=split1.name), split1.to_json())
-            await self.mock_adapter.set(pluggable_split_storage._prefix.format(split_name=split2.name), split2.to_json())
+            await self.mock_adapter.set(pluggable_split_storage._prefix.format(feature_flag_name=split1.name), split1.to_json())
+            await self.mock_adapter.set(pluggable_split_storage._prefix.format(feature_flag_name=split2.name), split2.to_json())
             assert(await pluggable_split_storage.get_split_names() == [split1.name, split2.name])
 
     @pytest.mark.asyncio
@@ -488,8 +488,8 @@ async def test_get_all(self):
             split2_temp['name'] = 'another_split'
             split2 = splits.from_raw(split2_temp)
 
-            await self.mock_adapter.set(pluggable_split_storage._prefix.format(split_name=split1.name), split1.to_json())
-            await self.mock_adapter.set(pluggable_split_storage._prefix.format(split_name=split2.name), split2.to_json())
+            await self.mock_adapter.set(pluggable_split_storage._prefix.format(feature_flag_name=split1.name), split1.to_json())
+            await self.mock_adapter.set(pluggable_split_storage._prefix.format(feature_flag_name=split2.name), split2.to_json())
             all_splits = await pluggable_split_storage.get_all()
             assert([all_splits[0].to_json(), all_splits[1].to_json()] == [split1.to_json(), split2.to_json()])
 
@@ -1158,12 +1158,12 @@ def test_record_config(self):
             pluggable_telemetry_storage = PluggableTelemetryStorage(self.mock_adapter, self.sdk_metadata, prefix=sprefix)
             self.config = {}
             self.extra_config = {}
-            def record_config_mock(config, extra_config):
+            def record_config_mock(config, extra_config, af, inf):
                 self.config = config
                 self.extra_config = extra_config
 
-            pluggable_telemetry_storage.record_config = record_config_mock
-            pluggable_telemetry_storage.record_config({'item': 'value'}, {'item2': 'value2'})
+            pluggable_telemetry_storage._tel_config.record_config = record_config_mock
+            pluggable_telemetry_storage.record_config({'item': 'value'}, {'item2': 'value2'}, 0, 0)
             assert(self.config == {'item': 'value'})
             assert(self.extra_config == {'item2': 'value2'})
 
@@ -1183,7 +1183,7 @@ def record_active_and_redundant_factories_mock(active_factory_count, redundant_f
                 self.active_factory_count = active_factory_count
                 self.redundant_factory_count = redundant_factory_count
 
-            pluggable_telemetry_storage.record_active_and_redundant_factories = record_active_and_redundant_factories_mock
+            pluggable_telemetry_storage._tel_config.record_active_and_redundant_factories = record_active_and_redundant_factories_mock
             pluggable_telemetry_storage.record_active_and_redundant_factories(2, 1)
             assert(self.active_factory_count == 2)
             assert(self.redundant_factory_count == 1)
@@ -1249,7 +1249,7 @@ def test_push_config_stats(self):
                     'eventsPushRate': 60,
                     'metricsRefreshRate': 10,
                     'storageType': None
-                    }, {}
+                    }, {}, 0, 0
             )
             pluggable_telemetry_storage.record_active_and_redundant_factories(2, 1)
             pluggable_telemetry_storage.push_config_stats()
@@ -1305,12 +1305,12 @@ async def test_record_config(self):
             pluggable_telemetry_storage = await PluggableTelemetryStorageAsync.create(self.mock_adapter, self.sdk_metadata, prefix=sprefix)
             self.config = {}
             self.extra_config = {}
-            async def record_config_mock(config, extra_config):
+            async def record_config_mock(config, extra_config, tf, ifs):
                 self.config = config
                 self.extra_config = extra_config
 
-            pluggable_telemetry_storage.record_config = record_config_mock
-            await pluggable_telemetry_storage.record_config({'item': 'value'}, {'item2': 'value2'})
+            pluggable_telemetry_storage._tel_config.record_config = record_config_mock
+            await pluggable_telemetry_storage.record_config({'item': 'value'}, {'item2': 'value2'}, 0, 0)
             assert(self.config == {'item': 'value'})
             assert(self.extra_config == {'item2': 'value2'})
 
@@ -1332,7 +1332,7 @@ async def record_active_and_redundant_factories_mock(active_factory_count, redun
                 self.active_factory_count = active_factory_count
                 self.redundant_factory_count = redundant_factory_count
 
-            pluggable_telemetry_storage.record_active_and_redundant_factories = record_active_and_redundant_factories_mock
+            pluggable_telemetry_storage._tel_config.record_active_and_redundant_factories = record_active_and_redundant_factories_mock
             await pluggable_telemetry_storage.record_active_and_redundant_factories(2, 1)
             assert(self.active_factory_count == 2)
             assert(self.redundant_factory_count == 1)
@@ -1401,7 +1401,7 @@ async def test_push_config_stats(self):
                     'eventsPushRate': 60,
                     'metricsRefreshRate': 10,
                     'storageType': None
-                    }, {}
+                    }, {}, 0, 0
             )
             await pluggable_telemetry_storage.record_active_and_redundant_factories(2, 1)
             await pluggable_telemetry_storage.push_config_stats()