fix return boolean for client.track when using redis pipeline

Author: chillaq

splitio/recorder/recorder.py

@@ -152,11 +152,18 @@ def record_track_stats(self, event, latency):
         :param event: events tracked
         :type event: splitio.models.events.EventWrapper
         """
-        pipe = self._make_pipe()
-        rc = self._event_sotrage.add_events_to_pipe(event, pipe)
-        self._telemetry_redis_storage.add_latency_to_pipe(MethodExceptionsAndLatencies.TRACK, latency, pipe)
-        result = pipe.execute()
-        if len(result) == 2:
-            self._event_sotrage.expire_keys(result[0], len(event))
-            self._telemetry_redis_storage.expire_latency_keys(result[1], latency)
-        return rc
+        try:
+            pipe = self._make_pipe()
+            self._event_sotrage.add_events_to_pipe(event, pipe)
+            self._telemetry_redis_storage.add_latency_to_pipe(MethodExceptionsAndLatencies.TRACK, latency, pipe)
+            result = pipe.execute()
+            if len(result) == 2:
+                self._event_sotrage.expire_keys(result[0], len(event))
+                self._telemetry_redis_storage.expire_latency_keys(result[1], latency)
+                if result[0] > 0:
+                    return True
+            return False
+        except Exception:  # pylint: disable=broad-except
+            _LOGGER.error('Error recording events')
+            _LOGGER.debug('Error: ', exc_info=True)
+            return False

tests/integration/test_client_e2e.py

@@ -269,6 +269,17 @@ def test_get_treatments_with_config(self):
             ('sample_feature', 'invalidKey', 'off'),
         )
 
+    def test_track(self):
+        """Test client.track()."""
+        try:
+            client = self.factory.client()
+        except:
+            pass
+        assert(client.track('user1', 'user', 'conversion'))
+        assert(not client.track(None, 'user', 'conversion'))
+        assert(not client.track('user1', None, 'conversion'))
+        assert(not client.track('user1', 'user', None))
+
     def test_manager_methods(self):
         """Test manager.split/splits."""
         try:
@@ -529,6 +540,13 @@ def test_manager_methods(self):
         assert len(manager.split_names()) == 7
         assert len(manager.splits()) == 7
 
+    def test_track(self):
+        """Test client.track()."""
+        client = self.factory.client()
+        assert(client.track('user1', 'user', 'conversion'))
+        assert(not client.track(None, 'user', 'conversion'))
+        assert(not client.track('user1', None, 'conversion'))
+        assert(not client.track('user1', 'user', None))
 
 class RedisIntegrationTests(object):
     """Redis storage-based integration tests."""
@@ -765,6 +783,14 @@ def test_get_treatments_with_config(self):
             ('sample_feature', 'invalidKey', 'off'),
         )
 
+    def test_track(self):
+        """Test client.track()."""
+        client = self.factory.client()
+        assert(client.track('user1', 'user', 'conversion'))
+        assert(not client.track(None, 'user', 'conversion'))
+        assert(not client.track('user1', None, 'conversion'))
+        assert(not client.track('user1', 'user', None))
+
     def test_manager_methods(self):
         """Test manager.split/splits."""
         try: