polish

Author: Bilal Al

splitio/models/grammar/matchers/semver.py

@@ -177,7 +177,7 @@ def _build(self, raw_matcher):
         :type raw_matcher: dict
         """
         self._data = raw_matcher.get('stringMatcherData')
-        self._semver = Semver(self._data)
+        self._semver = Semver.build(self._data)
 
     def _match(self, key, attributes=None, context=None):
         """
@@ -193,15 +193,19 @@ def _match(self, key, attributes=None, context=None):
         :returns: Wheter the match is successful.
         :rtype: bool
         """
-        if self._data is None:
+        if self._data is None or self._semver is None:
             _LOGGER.error("stringMatcherData is required for EQUAL_TO_SEMVER matcher type")
-            return None
+            return False
 
         matching_data = Sanitizer.ensure_string(self._get_matcher_input(key, attributes))
         if matching_data is None:
             return False
 
-        return self._semver.version == Semver(matching_data).version
+        matching_semver = Semver.build(matching_data)
+        if matching_semver is None:
+            return False
+
+        return self._semver.version == matching_semver.version
 
     def __str__(self):
         """Return string Representation."""
@@ -222,7 +226,7 @@ def _build(self, raw_matcher):
         :type raw_matcher: dict
         """
         self._data = raw_matcher.get('stringMatcherData')
-        self._semver = Semver(self._data)
+        self._semver = Semver.build(self._data)
 
     def _match(self, key, attributes=None, context=None):
         """
@@ -238,15 +242,19 @@ def _match(self, key, attributes=None, context=None):
         :returns: Wheter the match is successful.
         :rtype: bool
         """
-        if self._data is None:
+        if self._data is None or self._semver is None:
             _LOGGER.error("stringMatcherData is required for GREATER_THAN_OR_EQUAL_TO_SEMVER matcher type")
-            return None
+            return False
 
         matching_data = Sanitizer.ensure_string(self._get_matcher_input(key, attributes))
         if matching_data is None:
             return False
 
-        return Semver(matching_data).compare(self._semver) in [0, 1]
+        matching_semver = Semver.build(matching_data)
+        if matching_semver is None:
+            return False
+
+        return matching_semver.compare(self._semver) in [0, 1]
 
     def __str__(self):
         """Return string Representation."""

tests/models/grammar/test_matchers.py

@@ -909,10 +909,12 @@ def test_from_raw(self, mocker):
     def test_matcher_behaviour(self, mocker):
         """Test if the matcher works properly."""
         parsed = matchers.from_raw(self.raw)
-        assert parsed._match("2.1.8+rc")
+        assert not parsed._match("2.1.8+rc")
         assert parsed._match("2.1.8")
         assert not parsed._match("2.1.5")
         assert not parsed._match("2.1.5-rc1")
+        assert not parsed._match(None)
+        assert not parsed._match("semver")
 
     def test_to_json(self):
         """Test that the object serializes to JSON properly."""
@@ -953,6 +955,8 @@ def test_matcher_behaviour(self, mocker):
         assert parsed._match("2.1.11")
         assert not parsed._match("2.1.5")
         assert not parsed._match("2.1.5-rc1")
+        assert not parsed._match(None)
+        assert not parsed._match("semver")
 
     def test_to_json(self):
         """Test that the object serializes to JSON properly."""