Removed BUR from localhost legacy and yaml

Author: chillaq

splitio/client/factory.py

@@ -47,7 +47,7 @@
 from splitio.sync.synchronizer import SplitTasks, SplitSynchronizers, Synchronizer, \
     LocalhostSynchronizer, RedisSynchronizer
 from splitio.sync.manager import Manager, RedisManager
-from splitio.sync.split import SplitSynchronizer, LocalSplitSynchronizer, LocalhostMode
+from splitio.sync.split import SplitSynchronizer, LocalSplitSynchronizer, LocalhostMode, _ON_DEMAND_FETCH_BACKOFF_MAX_RETRIES
 from splitio.sync.segment import SegmentSynchronizer, LocalSegmentSynchronizer
 from splitio.sync.impression import ImpressionSynchronizer, ImpressionsCountSynchronizer
 from splitio.sync.event import EventSynchronizer
@@ -555,8 +555,13 @@ def _build_localhost_factory(cfg):
     ready_event = threading.Event()
     synchronizer = LocalhostSynchronizer(synchronizers, tasks)
     manager = Manager(ready_event, synchronizer, None, False, sdk_metadata, telemetry_runtime_producer)
-    initialization_thread = threading.Thread(target=manager.start, name="SDKInitializer", daemon=True)
-    initialization_thread.start()
+
+# TODO: BUR is only applied for Localhost JSON mode, in future legacy and yaml will also use BUR
+    if localhost_mode == LocalhostMode.JSON:
+        initialization_thread = threading.Thread(target=manager.start, args = [_ON_DEMAND_FETCH_BACKOFF_MAX_RETRIES], name="SDKInitializer", daemon=True)
+        initialization_thread.start()
+    else:
+        manager.start(1)
 
     recorder = StandardRecorder(
         ImpressionsManager(StrategyDebugMode(), telemetry_runtime_producer),

splitio/sync/synchronizer.py

@@ -512,7 +512,7 @@ def sync_all(self, till=None):
         Synchronize all splits.
         """
         self._backoff.reset()
-        remaining_attempts = _ON_DEMAND_FETCH_BACKOFF_MAX_RETRIES
+        remaining_attempts = _ON_DEMAND_FETCH_BACKOFF_MAX_RETRIES if till == None else till
         while remaining_attempts > 0:
             remaining_attempts -= 1
             try:
@@ -521,6 +521,10 @@ def sync_all(self, till=None):
                 _LOGGER.error('Failed syncing all')
                 _LOGGER.error(str(exc))
 
+# TODO: to be removed when legacy use BUR
+            if till == 1: # Legacy mode
+                raise Exception("Failed to fetch Splits")
+
             how_long = self._backoff.get()
             time.sleep(how_long)
 

tests/integration/test_client_e2e.py

@@ -1069,11 +1069,24 @@ def _synchronize_now(self):
         self.factory._sync_manager._synchronizer._split_synchronizers._split_sync.synchronize_splits()
 
     def test_incorrect_file_e2e(self):
-        factory = get_factory('localhost', config={'splitFile': 'filename'})
+        """Test initialize factory with a incorrect file name."""
+        # TODO: secontion below is removed when legacu use BUR
+        # legacy and yaml
+        exception_raised = False
+        factory = None
+        try:
+            factory = get_factory('localhost', config={'splitFile': 'filename'})
+        except Exception as e:
+            exception_raised = True
+
+        assert(exception_raised)
+
+        # json using BUR
+        factory = get_factory('localhost', config={'splitFile': 'filename.json'})
         exception_raised = False
         try:
             factory.block_until_ready(1)
-        except TimeoutException as e:
+        except Exception as e:
             exception_raised = True
 
         assert(exception_raised)
@@ -1082,6 +1095,7 @@ def test_incorrect_file_e2e(self):
         factory.destroy(event)
         event.wait()
 
+
     def test_localhost_e2e(self):
         """Instantiate a client with a YAML file and issue get_treatment() calls."""
         filename = os.path.join(os.path.dirname(__file__), 'files', 'file2.yaml')