Skip to content

Commit c8cbfc0

Browse files
authored
Merge branch 'development' into DW
2 parents ed62fc5 + 6f12c4f commit c8cbfc0

File tree

1 file changed

+31
-1
lines changed

1 file changed

+31
-1
lines changed

splitio/storage/redis.py

Lines changed: 31 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ def get(self, split_name): # pylint: disable=method-hidden
7171
"""
7272
try:
7373
raw = self._redis.get(self._get_key(split_name))
74+
_LOGGER.debug("Fetchting Split [%s] from redis" % split_name)
75+
_LOGGER.debug(raw)
7476
return splits.from_raw(json.loads(raw)) if raw is not None else None
7577
except RedisAdapterException:
7678
_LOGGER.error('Error fetching split from storage')
@@ -91,6 +93,8 @@ def fetch_many(self, split_names):
9193
try:
9294
keys = [self._get_key(split_name) for split_name in split_names]
9395
raw_splits = self._redis.mget(keys)
96+
_LOGGER.debug("Fetchting Splits [%s] from redis" % split_names)
97+
_LOGGER.debug(raw_splits)
9498
for i in range(len(split_names)):
9599
split = None
96100
try:
@@ -117,6 +121,7 @@ def is_valid_traffic_type(self, traffic_type_name): # pylint: disable=method-hi
117121
try:
118122
raw = self._redis.get(self._get_traffic_type_key(traffic_type_name))
119123
count = json.loads(raw) if raw else 0
124+
_LOGGER.debug("Fetching TrafficType [%s] count in redis: %s" % (traffic_type_name, count))
120125
return count > 0
121126
except RedisAdapterException:
122127
_LOGGER.error('Error fetching split from storage')
@@ -152,6 +157,7 @@ def get_change_number(self):
152157
"""
153158
try:
154159
stored_value = self._redis.get(self._SPLIT_TILL_KEY)
160+
_LOGGER.debug("Fetching Split Change Number from redis: %s" % stored_value)
155161
return json.loads(stored_value) if stored_value is not None else None
156162
except RedisAdapterException:
157163
_LOGGER.error('Error fetching split change number from storage')
@@ -176,6 +182,7 @@ def get_split_names(self):
176182
"""
177183
try:
178184
keys = self._redis.keys(self._get_key('*'))
185+
_LOGGER.debug("Fetchting Split names from redis: %s" % keys)
179186
return [key.replace(self._get_key(''), '') for key in keys]
180187
except RedisAdapterException:
181188
_LOGGER.error('Error fetching split names from storage')
@@ -199,7 +206,9 @@ def get_all_splits(self):
199206
keys = self._redis.keys(self._get_key('*'))
200207
to_return = []
201208
try:
209+
_LOGGER.debug("Fetchting all Splits from redis: %s" % keys)
202210
raw_splits = self._redis.mget(keys)
211+
_LOGGER.debug(raw_splits)
203212
for raw in raw_splits:
204213
try:
205214
to_return.append(splits.from_raw(json.loads(raw)))
@@ -276,6 +285,8 @@ def get(self, segment_name):
276285
"""
277286
try:
278287
keys = (self._redis.smembers(self._get_key(segment_name)))
288+
_LOGGER.debug("Fetchting Segment [%s] from redis" % segment_name)
289+
_LOGGER.debug(keys)
279290
till = self.get_change_number(segment_name)
280291
if not keys or till is None:
281292
return None
@@ -309,6 +320,7 @@ def get_change_number(self, segment_name):
309320
"""
310321
try:
311322
stored_value = self._redis.get(self._get_till_key(segment_name))
323+
_LOGGER.debug("Fetchting Change Number for Segment [%s] from redis: " % stored_value)
312324
return json.loads(stored_value) if stored_value is not None else None
313325
except RedisAdapterException:
314326
_LOGGER.error('Error fetching segment change number from storage')
@@ -348,7 +360,9 @@ def segment_contains(self, segment_name, key):
348360
:rtype: bool
349361
"""
350362
try:
351-
return self._redis.sismember(self._get_key(segment_name), key)
363+
res = self._redis.sismember(self._get_key(segment_name), key)
364+
_LOGGER.debug("Checking Segment [%s] contain key [%s] in redis: %s" % (segment_name, key, res))
365+
return res
352366
except RedisAdapterException:
353367
_LOGGER.error('Error testing members in segment stored in redis')
354368
_LOGGER.debug('Error: ', exc_info=True)
@@ -443,6 +457,8 @@ def add_impressions_to_pipe(self, impressions, pipe):
443457
:type pipe: redis.pipe
444458
"""
445459
bulk_impressions = self._wrap_impressions(impressions)
460+
_LOGGER.debug("Adding Impressions to redis key %s" % (self.IMPRESSIONS_QUEUE_KEY))
461+
_LOGGER.debug(bulk_impressions)
446462
pipe.rpush(self.IMPRESSIONS_QUEUE_KEY, *bulk_impressions)
447463

448464
def put(self, impressions):
@@ -457,6 +473,8 @@ def put(self, impressions):
457473
"""
458474
bulk_impressions = self._wrap_impressions(impressions)
459475
try:
476+
_LOGGER.debug("Adding Impressions to redis key %s" % (self.IMPRESSIONS_QUEUE_KEY))
477+
_LOGGER.debug(bulk_impressions)
460478
inserted = self._redis.rpush(self.IMPRESSIONS_QUEUE_KEY, *bulk_impressions)
461479
self.expire_key(inserted, len(bulk_impressions))
462480
return True
@@ -509,6 +527,8 @@ def add_events_to_pipe(self, events, pipe):
509527
:type pipe: redis.pipe
510528
"""
511529
bulk_events = self._wrap_events(events)
530+
_LOGGER.debug("Adding Events to redis key %s" % (self._EVENTS_KEY_TEMPLATE))
531+
_LOGGER.debug(bulk_events)
512532
pipe.rpush(self._EVENTS_KEY_TEMPLATE, *bulk_events)
513533

514534
def _wrap_events(self, events):
@@ -544,6 +564,8 @@ def put(self, events):
544564
key = self._EVENTS_KEY_TEMPLATE
545565
to_store = self._wrap_events(events)
546566
try:
567+
_LOGGER.debug("Adding Events to redis key %s" % (key))
568+
_LOGGER.debug(to_store)
547569
self._redis.rpush(key, *to_store)
548570
return True
549571
except RedisAdapterException:
@@ -632,6 +654,8 @@ def pop_config_tags(self):
632654

633655
def push_config_stats(self):
634656
"""push config stats to redis."""
657+
_LOGGER.debug("Adding Config stats to redis key %s" % (self._TELEMETRY_CONFIG_KEY))
658+
_LOGGER.debug(str(self._format_config_stats()))
635659
self._redis_client.hset(self._TELEMETRY_CONFIG_KEY, self._sdk_metadata.sdk_version + '/' + self._sdk_metadata.instance_name + '/' + self._sdk_metadata.instance_ip, str(self._format_config_stats()))
636660

637661
def _format_config_stats(self):
@@ -660,6 +684,9 @@ def add_latency_to_pipe(self, method, bucket, pipe):
660684
:param pipe: Redis pipe.
661685
:type pipe: redis.pipe
662686
"""
687+
_LOGGER.debug("Adding Latency stats to redis key %s" % (self._TELEMETRY_LATENCIES_KEY))
688+
_LOGGER.debug(self._sdk_metadata.sdk_version + '/' + self._sdk_metadata.instance_name + '/' + self._sdk_metadata.instance_ip + '/' +
689+
method.value + '/' + str(bucket))
663690
pipe.hincrby(self._TELEMETRY_LATENCIES_KEY, self._sdk_metadata.sdk_version + '/' + self._sdk_metadata.instance_name + '/' + self._sdk_metadata.instance_ip + '/' +
664691
method.value + '/' + str(bucket), 1)
665692

@@ -676,6 +703,9 @@ def record_exception(self, method):
676703
:param method: method name
677704
:type method: string
678705
"""
706+
_LOGGER.debug("Adding Excepction stats to redis key %s" % (self._TELEMETRY_EXCEPTIONS_KEY))
707+
_LOGGER.debug(self._sdk_metadata.sdk_version + '/' + self._sdk_metadata.instance_name + '/' + self._sdk_metadata.instance_ip + '/' +
708+
method.value)
679709
pipe = self._make_pipe()
680710
pipe.hincrby(self._TELEMETRY_EXCEPTIONS_KEY, self._sdk_metadata.sdk_version + '/' + self._sdk_metadata.instance_name + '/' + self._sdk_metadata.instance_ip + '/' +
681711
method.value, 1)

0 commit comments

Comments
 (0)