Skip to content

Commit bfe6ee7

Browse files
committed
update tests
1 parent 0451cb1 commit bfe6ee7

File tree

1 file changed

+17
-13
lines changed

1 file changed

+17
-13
lines changed

tests/client/test_client.py

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2889,9 +2889,10 @@ async def test_fallback_treatment_eval_exception(self, mocker):
28892889
telemetry_evaluation_producer = telemetry_producer.get_telemetry_evaluation_producer()
28902890
impmanager = ImpressionManager(StrategyOptimizedMode(), StrategyNoneMode(), telemetry_producer.get_telemetry_runtime_producer())
28912891
recorder = StandardRecorderAsync(impmanager, event_storage, impression_storage, telemetry_evaluation_producer, telemetry_producer.get_telemetry_runtime_producer())
2892-
2893-
async def manager_start_task():
2894-
pass
2892+
2893+
class TelemetrySubmitterMock():
2894+
async def synchronize_config(*_):
2895+
pass
28952896

28962897
factory = SplitFactoryAsync(mocker.Mock(),
28972898
{'splits': split_storage,
@@ -2904,19 +2905,19 @@ async def manager_start_task():
29042905
impmanager,
29052906
telemetry_producer,
29062907
telemetry_producer.get_telemetry_init_producer(),
2907-
mocker.Mock(),
2908-
manager_start_task
2908+
TelemetrySubmitterMock(),
2909+
None
29092910
)
29102911

2912+
ready_property = mocker.PropertyMock()
2913+
ready_property.return_value = True
2914+
type(factory).ready = ready_property
2915+
29112916
self.imps = None
29122917
async def put(impressions):
29132918
self.imps = impressions
29142919
impression_storage.put = put
2915-
2916-
class TelemetrySubmitterMock():
2917-
async def synchronize_config(*_):
2918-
pass
2919-
factory._telemetry_submitter = TelemetrySubmitterMock()
2920+
29202921
client = ClientAsync(factory, recorder, True, FallbackTreatmentCalculator(FallbackTreatmentsConfiguration(FallbackTreatment("on-global", '{"prop": "val"}'))))
29212922

29222923
async def get_feature_flag_names_by_flag_sets(*_):
@@ -3040,8 +3041,6 @@ async def test_fallback_treatment_exception(self, mocker):
30403041
telemetry_producer = TelemetryStorageProducerAsync(telemetry_storage)
30413042
impmanager = ImpressionManager(StrategyOptimizedMode(), StrategyNoneMode(), telemetry_producer.get_telemetry_runtime_producer())
30423043
recorder = StandardRecorderAsync(impmanager, event_storage, impression_storage, telemetry_producer.get_telemetry_evaluation_producer(), telemetry_producer.get_telemetry_runtime_producer())
3043-
async def manager_start_task():
3044-
pass
30453044

30463045
factory = SplitFactoryAsync(mocker.Mock(),
30473046
{'splits': split_storage,
@@ -3055,8 +3054,11 @@ async def manager_start_task():
30553054
telemetry_producer,
30563055
telemetry_producer.get_telemetry_init_producer(),
30573056
mocker.Mock(),
3058-
manager_start_task
3057+
None
30593058
)
3059+
ready_property = mocker.PropertyMock()
3060+
ready_property.return_value = True
3061+
type(factory).ready = ready_property
30603062

30613063
self.imps = None
30623064
async def put(impressions):
@@ -3067,6 +3069,7 @@ class TelemetrySubmitterMock():
30673069
def synchronize_config(*_):
30683070
pass
30693071
factory._telemetry_submitter = TelemetrySubmitterMock()
3072+
30703073
client = ClientAsync(factory, recorder, True, FallbackTreatmentCalculator(FallbackTreatmentsConfiguration(FallbackTreatment("on-global"))))
30713074

30723075
async def context_for(*_):
@@ -3151,6 +3154,7 @@ class TelemetrySubmitterMock():
31513154
def synchronize_config(*_):
31523155
pass
31533156
factory._telemetry_submitter = TelemetrySubmitterMock()
3157+
31543158
client = ClientAsync(factory, recorder, True, FallbackTreatmentCalculator(FallbackTreatmentsConfiguration(FallbackTreatment("on-global"))))
31553159
ready_property = mocker.PropertyMock()
31563160
ready_property.return_value = False

0 commit comments

Comments
 (0)