polishing

Author: chillaq

splitio/sync/split.py

@@ -481,19 +481,16 @@ def _santizie_condition(self, split):
         found_all_keys_matcher = False
         if 'conditions' not in split or split['conditions'] is None:
             split['conditions'] = []
-        conditions_count = len(split['conditions'])
-        count = 0
-        for condition in split['conditions']:
-            count += 1
-            if count == conditions_count: # checking only last condition
-                if 'conditionType' in condition:
-                    if condition['conditionType'] == 'ROLLOUT':
-                        if 'matcherGroup' in condition:
-                            if 'matchers' in condition['matcherGroup']:
-                                for matcher in condition['matcherGroup']['matchers']:
-                                    if matcher['matcherType'] == 'ALL_KEYS':
-                                        found_all_keys_matcher = True
-                                        break
+        if len(split['conditions']) > 0:
+            last_condition = split['conditions'][-1]
+            if 'conditionType' in last_condition:
+                if last_condition['conditionType'] == 'ROLLOUT':
+                    if 'matcherGroup' in last_condition:
+                        if 'matchers' in last_condition['matcherGroup']:
+                            for matcher in last_condition['matcherGroup']['matchers']:
+                                if matcher['matcherType'] == 'ALL_KEYS':
+                                    found_all_keys_matcher = True
+                                    break
 
         if not found_all_keys_matcher:
             _LOGGER.debug("Missing default rule condition for split: %s, adding default rule with 100%% off treatment", split['name'])

splitio/sync/synchronizer.py

@@ -551,7 +551,7 @@ def synchronize_splits(self):
             for segment in self._split_synchronizers.split_sync.synchronize_splits():
                     if not self._split_synchronizers.segment_sync.segment_exist_in_storage(segment):
                         new_segments.append(segment)
-            if len(new_segments) != 0:
+            if len(new_segments) > 0:
                 _LOGGER.debug('Synching Segments: %s', ','.join(new_segments))
                 success = self._split_synchronizers.segment_sync.synchronize_segments(new_segments)
                 if not success: