added character length for regex check

Author: chillaq

splitio/client/input_validator.py

@@ -80,7 +80,7 @@ def _check_string_not_empty(value, name, operation):
     return True
 
 
-def _check_string_matches(value, operation, pattern, name):
+def _check_string_matches(value, operation, pattern, name, length):
     """
     Check if value is adhere to a regular expression passed.
 
@@ -98,9 +98,9 @@ def _check_string_matches(value, operation, pattern, name):
             '%s: you passed %s, event_type must ' +
             'adhere to the regular expression %s. ' +
             'This means %s must be alphanumeric, cannot be more ' +
-            'than 80 characters long, and can only include a dash, underscore, ' +
+            'than %s characters long, and can only include a dash, underscore, ' +
             'period, or colon as separators of alphanumeric characters.',
-            operation, value, pattern, name
+            operation, value, pattern, name, length
         )
         return False
     return True
@@ -323,7 +323,7 @@ def validate_event_type(event_type):
     if (not _check_not_null(event_type, 'event_type', 'track')) or \
        (not _check_is_string(event_type, 'event_type', 'track')) or \
        (not _check_string_not_empty(event_type, 'event_type', 'track')) or \
-       (not _check_string_matches(event_type, 'track', EVENT_TYPE_PATTERN, 'an event name')):
+       (not _check_string_matches(event_type, 'track', EVENT_TYPE_PATTERN, 'an event name', 80)):
         return None
     return event_type
 
@@ -591,7 +591,7 @@ def validate_flag_sets(flag_sets, method_name):
         flag_set = _remove_empty_spaces(flag_set, 'flag set', method_name)
         flag_set = _convert_str_to_lower(flag_set, 'flag set', method_name)
 
-        if not _check_string_matches(flag_set, method_name, _FLAG_SETS_REGEX, 'a flag set'):
+        if not _check_string_matches(flag_set, method_name, _FLAG_SETS_REGEX, 'a flag set', 50):
             continue
 
         sanitized_flag_sets.add(flag_set)

tests/client/test_input_validator.py

@@ -666,10 +666,10 @@ def test_track(self, mocker):
         assert _logger.error.mock_calls == [
             mocker.call("%s: you passed %s, event_type must adhere to the regular "
                         "expression %s. This means "
-                        "%s must be alphanumeric, cannot be more than 80 "
+                        "%s must be alphanumeric, cannot be more than %s "
                         "characters long, and can only include a dash, underscore, "
                         "period, or colon as separators of alphanumeric characters.",
-                        'track', '@@', '^[a-zA-Z0-9][-_.:a-zA-Z0-9]{0,79}$', 'an event name')
+                        'track', '@@', '^[a-zA-Z0-9][-_.:a-zA-Z0-9]{0,79}$', 'an event name', 80)
         ]
 
         _logger.reset_mock()