Skip to content

Commit a81f503

Browse files
author
Bilal Al
committed
updated latest semver code
1 parent ff12ee0 commit a81f503

File tree

10 files changed

+95
-93
lines changed

10 files changed

+95
-93
lines changed

setup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
'flake8',
99
'pytest==7.0.1',
1010
'pytest-mock==3.11.1',
11-
'coverage==7.2,7',
11+
'coverage',
1212
'pytest-cov==4.1.0',
1313
'importlib-metadata==6.7',
1414
'tomli==1.2.3',
@@ -45,7 +45,7 @@
4545
'test': TESTS_REQUIRES,
4646
'redis': ['redis>=2.10.5'],
4747
'uwsgi': ['uwsgi>=2.0.0'],
48-
'cpphash': ['mmh3cffi==0.2.1'],
48+
'cpphash': ['mmh3cffi==0.2.1']
4949
},
5050
setup_requires=['pytest-runner', 'pluggy==1.0.0;python_version<"3.8"'],
5151
classifiers=[

splitio/api/auth.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def authenticate(self):
4444
try:
4545
response = self._client.get(
4646
'auth',
47-
'/v2/auth?s=' + SPEC_VERSION,
47+
'v2/auth?s=' + SPEC_VERSION,
4848
self._sdk_key,
4949
extra_headers=self._metadata,
5050
)
@@ -55,7 +55,7 @@ def authenticate(self):
5555
else:
5656
if (response.status_code >= 400 and response.status_code < 500):
5757
self._telemetry_runtime_producer.record_auth_rejections()
58-
raise APIException(response.body, response.status_code, response.headers)
58+
raise APIException(response.body, response.status_code)
5959
except HttpClientException as exc:
6060
_LOGGER.error('Exception raised while authenticating')
6161
_LOGGER.debug('Exception information: ', exc_info=True)
@@ -91,7 +91,7 @@ async def authenticate(self):
9191
try:
9292
response = await self._client.get(
9393
'auth',
94-
'v2/auth',
94+
'v2/auth?s=' + SPEC_VERSION,
9595
self._sdk_key,
9696
extra_headers=self._metadata,
9797
)
@@ -102,7 +102,7 @@ async def authenticate(self):
102102
else:
103103
if (response.status_code >= 400 and response.status_code < 500):
104104
await self._telemetry_runtime_producer.record_auth_rejections()
105-
raise APIException(response.body, response.status_code, response.headers)
105+
raise APIException(response.body, response.status_code)
106106
except HttpClientException as exc:
107107
_LOGGER.error('Exception raised while authenticating')
108108
_LOGGER.debug('Exception information: ', exc_info=True)

splitio/sync/segment.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,14 +331,14 @@ async def synchronize_segment(self, segment_name, till=None):
331331
:return: True if no error occurs. False otherwise.
332332
:rtype: bool
333333
"""
334-
fetch_options = FetchOptions(True) # Set Cache-Control to no-cache
334+
fetch_options = FetchOptions(True, spec=None) # Set Cache-Control to no-cache
335335
successful_sync, remaining_attempts, change_number = await self._attempt_segment_sync(segment_name, fetch_options, till)
336336
attempts = _ON_DEMAND_FETCH_BACKOFF_MAX_RETRIES - remaining_attempts
337337
if successful_sync: # succedeed sync
338338
_LOGGER.debug('Refresh completed in %d attempts.', attempts)
339339
return True
340340

341-
with_cdn_bypass = FetchOptions(True, change_number) # Set flag for bypassing CDN
341+
with_cdn_bypass = FetchOptions(True, change_number, spec=None) # Set flag for bypassing CDN
342342
without_cdn_successful_sync, remaining_attempts, change_number = await self._attempt_segment_sync(segment_name, with_cdn_bypass, till)
343343
without_cdn_attempts = _ON_DEMAND_FETCH_BACKOFF_MAX_RETRIES - remaining_attempts
344344
if without_cdn_successful_sync:

tests/api/test_auth.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def test_auth(self, mocker):
3434
call_made = httpclient.get.mock_calls[0]
3535

3636
# validate positional arguments
37-
assert call_made[1] == ('auth', '/v2/auth?s=1.1', 'some_api_key')
37+
assert call_made[1] == ('auth', 'v2/auth?s=1.1', 'some_api_key')
3838

3939
# validate key-value args (headers)
4040
assert call_made[2]['extra_headers'] == {
@@ -89,7 +89,7 @@ async def get(verb, url, key, extra_headers):
8989

9090
# validate positional arguments
9191
assert self.verb == 'auth'
92-
assert self.url == 'v2/auth'
92+
assert self.url == 'v2/auth?s=1.1'
9393
assert self.key == 'some_api_key'
9494
assert self.headers == {
9595
'SplitSDKVersion': 'python-%s' % __version__,

tests/api/test_segments_api.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ async def get(verb, url, key, query, extra_headers):
8383
return client.HttpResponse(200, '{"prop1": "value1"}', {})
8484
httpclient.get = get
8585

86-
response = await segment_api.fetch_segment('some_segment', 123, FetchOptions())
86+
response = await segment_api.fetch_segment('some_segment', 123, FetchOptions(None, None, None, None))
8787
assert response['prop1'] == 'value1'
8888
assert self.verb == 'sdk'
8989
assert self.url == 'segmentChanges/some_segment'
@@ -96,7 +96,7 @@ async def get(verb, url, key, query, extra_headers):
9696
assert self.query == {'since': 123}
9797

9898
httpclient.reset_mock()
99-
response = await segment_api.fetch_segment('some_segment', 123, FetchOptions(True))
99+
response = await segment_api.fetch_segment('some_segment', 123, FetchOptions(True, None, None, None))
100100
assert response['prop1'] == 'value1'
101101
assert self.verb == 'sdk'
102102
assert self.url == 'segmentChanges/some_segment'
@@ -110,7 +110,7 @@ async def get(verb, url, key, query, extra_headers):
110110
assert self.query == {'since': 123}
111111

112112
httpclient.reset_mock()
113-
response = await segment_api.fetch_segment('some_segment', 123, FetchOptions(True, 123))
113+
response = await segment_api.fetch_segment('some_segment', 123, FetchOptions(True, 123, None, None))
114114
assert response['prop1'] == 'value1'
115115
assert self.verb == 'sdk'
116116
assert self.url == 'segmentChanges/some_segment'
@@ -128,6 +128,6 @@ def raise_exception(*args, **kwargs):
128128
raise client.HttpClientException('some_message')
129129
httpclient.get = raise_exception
130130
with pytest.raises(APIException) as exc_info:
131-
response = await segment_api.fetch_segment('some_segment', 123, FetchOptions())
131+
response = await segment_api.fetch_segment('some_segment', 123, FetchOptions(None, None, None, None))
132132
assert exc_info.type == APIException
133133
assert exc_info.value.message == 'some_message'

tests/api/test_splits_api.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def test_fetch_split_changes(self, mocker):
3636
'SplitSDKMachineName': 'some',
3737
'Cache-Control': 'no-cache'
3838
},
39-
query={'since': 123, 'till': 123, 'sets': 'set3'})]
39+
query={'s': '1.1', 'since': 123, 'till': 123, 'sets': 'set3'})]
4040

4141
httpclient.reset_mock()
4242
response = split_api.fetch_splits(123, FetchOptions(True, 123, 'set3'))
@@ -92,7 +92,7 @@ async def get(verb, url, key, query, extra_headers):
9292
'SplitSDKMachineIP': '1.2.3.4',
9393
'SplitSDKMachineName': 'some'
9494
}
95-
assert self.query == {'since': 123, 'sets': 'set1,set2'}
95+
assert self.query == {'s': '1.1', 'since': 123, 'sets': 'set1,set2'}
9696

9797
httpclient.reset_mock()
9898
response = await split_api.fetch_splits(123, FetchOptions(True, 123, 'set3'))
@@ -106,7 +106,7 @@ async def get(verb, url, key, query, extra_headers):
106106
'SplitSDKMachineName': 'some',
107107
'Cache-Control': 'no-cache'
108108
}
109-
assert self.query == {'since': 123, 'till': 123, 'sets': 'set3'}
109+
assert self.query == {'s': '1.1', 'since': 123, 'till': 123, 'sets': 'set3'}
110110

111111
httpclient.reset_mock()
112112
response = await split_api.fetch_splits(123, FetchOptions(True, 123))
@@ -120,7 +120,7 @@ async def get(verb, url, key, query, extra_headers):
120120
'SplitSDKMachineName': 'some',
121121
'Cache-Control': 'no-cache'
122122
}
123-
assert self.query == {'since': 123, 'till': 123}
123+
assert self.query == {'s': '1.1', 'since': 123, 'till': 123}
124124

125125
httpclient.reset_mock()
126126
def raise_exception(*args, **kwargs):

tests/client/test_manager.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
"""SDK main manager test module."""
2+
import pytest
3+
24
from splitio.client.factory import SplitFactory
35
from splitio.client.manager import SplitManager, SplitManagerAsync, _LOGGER as _logger
46
from splitio.models import splits

0 commit comments

Comments
 (0)