Skip to content

Commit a69f8f6

Browse files
authored
Merge pull request #465 from splitio/flagsets-tests-e2e
Flagsets tests e2e
2 parents db469a5 + 38329f2 commit a69f8f6

File tree

5 files changed

+804
-1009
lines changed

5 files changed

+804
-1009
lines changed

splitio/storage/pluggable.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,8 @@ def get_feature_flags_by_sets(self, flag_sets):
9090
if sets_to_fetch == []:
9191
return []
9292

93-
keys = [self._prefix(feature_flag_name) for feature_flag_name in sets_to_fetch]
94-
result_sets = self._pluggable_adapter.get_many(keys)
95-
return list(combine_valid_flag_sets(result_sets))
93+
keys = [self._feature_flag_set_prefix.format(flag_set=flag_set) for flag_set in sets_to_fetch]
94+
return self._pluggable_adapter.get_many(keys)
9695
except Exception:
9796
_LOGGER.error('Error fetching feature flag from storage')
9897
_LOGGER.debug('Error: ', exc_info=True)

tests/integration/files/splitChanges.json

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,8 @@
5858
}
5959
]
6060
}
61-
]
61+
],
62+
"sets": ["set1", "set2"]
6263
},
6364
{
6465
"orgId": null,
@@ -95,7 +96,8 @@
9596
}
9697
]
9798
}
98-
]
99+
],
100+
"sets": ["set4"]
99101
},
100102
{
101103
"orgId": null,
@@ -136,7 +138,8 @@
136138
}
137139
]
138140
}
139-
]
141+
],
142+
"sets": ["set3"]
140143
},
141144
{
142145
"orgId": null,
@@ -199,7 +202,8 @@
199202
}
200203
]
201204
}
202-
]
205+
],
206+
"sets": ["set1"]
203207
},
204208
{
205209
"orgId": null,

0 commit comments

Comments
 (0)