Skip to content

Commit 970f411

Browse files
author
Bilal Al
committed
added removing zero leading integer in pre-release
1 parent 9204763 commit 970f411

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

splitio/models/grammar/matchers/semver.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"""Semver matcher classes."""
22
import logging
3-
3+
import pytest
44
from splitio.models.grammar.matchers.base import Matcher
55
from splitio.models.grammar.matchers.string import Sanitizer
66

@@ -53,7 +53,10 @@ def _parse(self, version):
5353
raise RuntimeError("Pre-release is empty despite delimeter exists: " + version)
5454

5555
without_metadata = without_metadata[:index]
56-
self._pre_release = pre_release_data.split(self._VALUE_DELIMITER)
56+
for pre_digit in pre_release_data.split(self._VALUE_DELIMITER):
57+
if pre_digit.isnumeric():
58+
pre_digit = str(int(pre_digit))
59+
self._pre_release.append(pre_digit)
5760

5861
self._set_major_minor_and_patch(without_metadata)
5962

tests/models/grammar/test_semver.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,3 +53,7 @@ def test_compare(self):
5353
assert version2.compare(version1) >= 0 and version3.compare(version2) >= 0
5454
else:
5555
assert version2.compare(version1) < 0 or version3.compare(version2) < 0
56+
57+
def test_leading_zeros(self):
58+
assert Semver.build('1.01.2').version == '1.1.2'
59+
assert Semver.build('1.01.2-rc.01').version == '1.1.2-rc.1'

0 commit comments

Comments
 (0)