cleanup

Author: chillaq

splitio/push/workers.py

@@ -235,7 +235,7 @@ def _run(self):
                         _LOGGER.debug('Exception information: ', exc_info=True)
                         pass
                 sync_result = self._handler(event.change_number)
-                if not sync_result.success and sync_result.error_code == 414:
+                if not sync_result.success and sync_result.error_code is not None and sync_result.error_code == 414:
                     _LOGGER.error("URI too long exception caught, sync failed")
 
                 if not sync_result.success:

splitio/sync/synchronizer.py

@@ -425,7 +425,7 @@ def sync_all(self, max_retry_attempts=_SYNC_ALL_NO_RETRIES):
         while True:
             try:
                 sync_result = self.synchronize_splits(None, False)
-                if not sync_result.success and sync_result.error_code == 414:
+                if not sync_result.success and sync_result.error_code is not None and sync_result.error_code == 414:
                     _LOGGER.error("URI too long exception caught, aborting retries")
                     break
 
@@ -587,7 +587,7 @@ async def sync_all(self, max_retry_attempts=_SYNC_ALL_NO_RETRIES):
         while True:
             try:
                 sync_result = await self.synchronize_splits(None, False)
-                if not sync_result.success and sync_result.error_code == 414:
+                if not sync_result.success and sync_result.error_code is not None and sync_result.error_code == 414:
                     _LOGGER.error("URI too long exception caught, aborting retries")
                     break
 
@@ -601,10 +601,6 @@ async def sync_all(self, max_retry_attempts=_SYNC_ALL_NO_RETRIES):
 
                 # All is good
                 return
-            except APIUriException as exc:
-                _LOGGER.error("URI too long exception, aborting retries.")
-                _LOGGER.debug('Error: ', exc_info=True)
-                break
             except Exception as exc:  # pylint:disable=broad-except
                 _LOGGER.error("Exception caught when trying to sync all data: %s", str(exc))
                 _LOGGER.debug('Error: ', exc_info=True)