Added lock back to FlagSe lib

Author: Bilal Al

splitio/recorder/recorder.py

@@ -234,7 +234,7 @@ async def record_treatment_stats(self, impressions, latency, operation, method_n
                 self._imp_counter.track(for_counter)
             if len(for_unique_keys_tracker) > 0:
                 unique_keys_coros = [self._unique_keys_tracker.track(item[0], item[1]) for item in for_unique_keys_tracker]
-                asyncio.gather(*unique_keys_coros)
+                await asyncio.gather(*unique_keys_coros)
         except Exception:  # pylint: disable=broad-except
             _LOGGER.error('Error recording impressions')
             _LOGGER.debug('Error: ', exc_info=True)
@@ -400,7 +400,7 @@ async def record_treatment_stats(self, impressions, latency, operation, method_n
                 self._imp_counter.track(for_counter)
             if len(for_unique_keys_tracker) > 0:
                 unique_keys_coros = [self._unique_keys_tracker.track(item[0], item[1]) for item in for_unique_keys_tracker]
-                asyncio.gather(*unique_keys_coros)
+                await asyncio.gather(*unique_keys_coros)
         except Exception:  # pylint: disable=broad-except
             _LOGGER.error('Error recording impressions')
             _LOGGER.debug('Error: ', exc_info=True)

splitio/storage/inmemmory.py

@@ -21,6 +21,7 @@ class FlagSets(object):
     def __init__(self, flag_sets=[]):
         """Constructor."""
         self.sets_feature_flag_map = {}
+        self._lock = threading.RLock()
         for flag_set in flag_sets:
             self.sets_feature_flag_map[flag_set] = set()
 
@@ -32,7 +33,8 @@ def flag_set_exist(self, flag_set):
 
         :rtype: bool
         """
-        return flag_set in self.sets_feature_flag_map.keys()
+        with self._lock:
+            return flag_set in self.sets_feature_flag_map.keys()
 
     def get_flag_set(self, flag_set):
         """
@@ -42,25 +44,28 @@ def get_flag_set(self, flag_set):
 
         :rtype: list(str)
         """
-        return self.sets_feature_flag_map.get(flag_set)
+        with self._lock:
+            return self.sets_feature_flag_map.get(flag_set)
 
     def _add_flag_set(self, flag_set):
         """
         Add new flag set to storage
         :param flag_set: set name
         :type flag_set: str
         """
-        if not self.flag_set_exist(flag_set):
-            self.sets_feature_flag_map[flag_set] = set()
+        with self._lock:
+            if not self.flag_set_exist(flag_set):
+                self.sets_feature_flag_map[flag_set] = set()
 
     def _remove_flag_set(self, flag_set):
         """
         Remove existing flag set from storage
         :param flag_set: set name
         :type flag_set: str
         """
-        if self.flag_set_exist(flag_set):
-            del self.sets_feature_flag_map[flag_set]
+        with self._lock:
+            if self.flag_set_exist(flag_set):
+                del self.sets_feature_flag_map[flag_set]
 
     def add_feature_flag_to_flag_set(self, flag_set, feature_flag):
         """
@@ -70,8 +75,9 @@ def add_feature_flag_to_flag_set(self, flag_set, feature_flag):
         :param feature_flag: feature flag name
         :type feature_flag: str
         """
-        if self.flag_set_exist(flag_set):
-            self.sets_feature_flag_map[flag_set].add(feature_flag)
+        with self._lock:
+            if self.flag_set_exist(flag_set):
+                self.sets_feature_flag_map[flag_set].add(feature_flag)
 
     def remove_feature_flag_to_flag_set(self, flag_set, feature_flag):
         """
@@ -81,8 +87,9 @@ def remove_feature_flag_to_flag_set(self, flag_set, feature_flag):
         :param feature_flag: feature flag name
         :type feature_flag: str
         """
-        if self.flag_set_exist(flag_set):
-            self.sets_feature_flag_map[flag_set].remove(feature_flag)
+        with self._lock:
+            if self.flag_set_exist(flag_set):
+                self.sets_feature_flag_map[flag_set].remove(feature_flag)
 
     def update_flag_set(self, flag_sets, feature_flag_name, should_filter):
         if flag_sets is not None: