Merge pull request #367 from splitio/dw-fix-missing-defaulttreatment-localhost

Fixed setting defaultTreatment to control when missing

Author: chillaq

splitio/sync/split.py

@@ -454,7 +454,7 @@ def _sanitize_split_elements(self, parsed_splits):
                             ('seed', int(get_current_epoch_time_ms() / 1000), None, None, None, [0]),
                             ('status', splits.Status.ACTIVE.value, None, None, [e.value for e in splits.Status], None),
                             ('killed', False, None, None, None, None),
-                            ('defaultTreatment', 'on', None, None, None, ['', ' ']),
+                            ('defaultTreatment', 'control', None, None, None, ['', ' ']),
                             ('changeNumber', 0, 0, None, None, None),
                             ('algo', 2, 2, 2, None, None)]:
                 split = util._sanitize_object_element(split, 'split', element[0], element[1], lower_value=element[2], upper_value=element[3], in_list=element[4], not_in_list=element[5])

tests/sync/test_splits_synchronizer.py

@@ -459,12 +459,12 @@ def test_split_elements_sanitization(self, mocker):
         # test 'defaultTreatment' is set to on when None
         split = splits_json["splitChange1_1"]["splits"].copy()
         split[0]['defaultTreatment'] = None
-        assert (split_synchronizer._sanitize_split_elements(split) == splits_json["splitChange1_1"]["splits"])
+        assert (split_synchronizer._sanitize_split_elements(split)[0]['defaultTreatment'] == 'control')
 
         # test 'defaultTreatment' is set to on when its empty
         split = splits_json["splitChange1_1"]["splits"].copy()
         split[0]['defaultTreatment'] = ' '
-        assert (split_synchronizer._sanitize_split_elements(split) == splits_json["splitChange1_1"]["splits"])
+        assert (split_synchronizer._sanitize_split_elements(split)[0]['defaultTreatment'] == 'control')
 
         # test 'changeNumber' is set to 0 when None
         split = splits_json["splitChange1_1"]["splits"].copy()