Skip to content

Commit 6836183

Browse files
committed
dw - updated feature in logs and func comments for input_validator
1 parent 4e2b33a commit 6836183

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

splitio/client/input_validator.py

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ def _remove_empty_spaces(value, operation):
192192
"""
193193
strip_value = value.strip()
194194
if value != strip_value:
195-
_LOGGER.warning("%s: feature_name '%s' has extra whitespace, trimming.", operation, value)
195+
_LOGGER.warning("%s: feature_flag_name '%s' has extra whitespace, trimming.", operation, value)
196196
return strip_value
197197

198198

@@ -234,9 +234,9 @@ def validate_key(key, method_name):
234234

235235
def validate_feature_name(feature_name, should_validate_existance, split_storage, method_name):
236236
"""
237-
Check if feature_name is valid for get_treatment.
237+
Check if feature flag name is valid for get_treatment.
238238
239-
:param feature_name: feature_name to be checked
239+
:param feature_name: feature flag name to be checked
240240
:type feature_name: str
241241
:return: feature_name
242242
:rtype: str|None
@@ -248,7 +248,7 @@ def validate_feature_name(feature_name, should_validate_existance, split_storage
248248

249249
if should_validate_existance and split_storage.get(feature_name) is None:
250250
_LOGGER.warning(
251-
"%s: you passed \"%s\" that does not exist in this environment, "
251+
"%s: you passed feature flag \"%s\" that does not exist in this environment, "
252252
"please double check what Splits exist in the web console.",
253253
method_name,
254254
feature_name
@@ -346,9 +346,9 @@ def validate_value(value):
346346

347347
def validate_manager_feature_name(feature_name, should_validate_existance, split_storage):
348348
"""
349-
Check if feature_name is valid for track.
349+
Check if feature flag name is valid for track.
350350
351-
:param feature_name: feature_name to be checked
351+
:param feature_name: feature flag name to be checked
352352
:type feature_name: str
353353
:return: feature_name
354354
:rtype: str|None
@@ -360,7 +360,7 @@ def validate_manager_feature_name(feature_name, should_validate_existance, split
360360

361361
if should_validate_existance and split_storage.get(feature_name) is None:
362362
_LOGGER.warning(
363-
"split: you passed \"%s\" that does not exist in this environment, "
363+
"split: you passed feature flag \"%s\" that does not exist in this environment, "
364364
"please double check what Splits exist in the web console.",
365365
feature_name
366366
)
@@ -376,27 +376,27 @@ def validate_features_get_treatments( # pylint: disable=invalid-name
376376
split_storage=None
377377
):
378378
"""
379-
Check if features is valid for get_treatments.
379+
Check if feature flags is valid for get_treatments.
380380
381-
:param features: array of features
381+
:param features: array of feature flags
382382
:type features: list
383383
:return: filtered_features
384384
:rtype: tuple
385385
"""
386386
if features is None or not isinstance(features, list):
387-
_LOGGER.error("%s: feature_names must be a non-empty array.", method_name)
387+
_LOGGER.error("%s: feature flag names must be a non-empty array.", method_name)
388388
return None, None
389389
if not features:
390-
_LOGGER.error("%s: feature_names must be a non-empty array.", method_name)
390+
_LOGGER.error("%s: feature flag names must be a non-empty array.", method_name)
391391
return None, None
392392
filtered_features = set(
393393
_remove_empty_spaces(feature, method_name) for feature in features
394394
if feature is not None and
395-
_check_is_string(feature, 'feature_name', method_name) and
396-
_check_string_not_empty(feature, 'feature_name', method_name)
395+
_check_is_string(feature, 'feature flag name', method_name) and
396+
_check_string_not_empty(feature, 'feature flag name', method_name)
397397
)
398398
if not filtered_features:
399-
_LOGGER.error("%s: feature_names must be a non-empty array.", method_name)
399+
_LOGGER.error("%s: feature flag names must be a non-empty array.", method_name)
400400
return None, None
401401

402402
if not should_validate_existance:
@@ -405,7 +405,7 @@ def validate_features_get_treatments( # pylint: disable=invalid-name
405405
valid_missing_features = set(f for f in filtered_features if split_storage.get(f) is None)
406406
for missing_feature in valid_missing_features:
407407
_LOGGER.warning(
408-
"%s: you passed \"%s\" that does not exist in this environment, "
408+
"%s: you passed feature flag \"%s\" that does not exist in this environment, "
409409
"please double check what Splits exist in the web console.",
410410
method_name,
411411
missing_feature
@@ -415,9 +415,9 @@ def validate_features_get_treatments( # pylint: disable=invalid-name
415415

416416
def generate_control_treatments(features, method_name):
417417
"""
418-
Generate valid features to control.
418+
Generate valid feature flags to control.
419419
420-
:param features: array of features
420+
:param features: array of feature flags
421421
:type features: list
422422
:return: dict
423423
:rtype: dict|None

0 commit comments

Comments
 (0)