polish

Author: Bilal Al

splitio/models/grammar/matchers/semver.py

@@ -1,5 +1,6 @@
 """Semver matcher classes."""
 import logging
+import pytest
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -47,6 +48,9 @@ def _parse(self, version):
             self._is_stable = True
         else:
             pre_release_data = without_metadata[index+1:]
+            if pre_release_data == "":
+                raise RuntimeError("Pre-release is empty despite delimeter exists: " + version)
+
             without_metadata = without_metadata[:index]
             self._pre_release = pre_release_data.split(self._VALUE_DELIMITER)
 
@@ -63,7 +67,10 @@ def remove_metadata_if_exists(self, version):
         if index == -1:
             return version
 
-        self._metadata = version[index:]
+        self._metadata = version[index+1:]
+        if self._metadata == "":
+            raise RuntimeError("Metadata is empty despite delimeter exists: " + version)
+
         return  version[:index]
 
     def set_major_minor_and_patch(self, version):

tests/models/grammar/files/invalid-semantic-versions.csv

@@ -23,4 +23,6 @@ beta
 1.2-RC-SNAPSHOT
 -1.0.3-gamma+b7718
 +justmeta
+1.1.1+
+1.1.1-
 #99999999999999999999999.999999999999999999.99999999999999999----RC-SNAPSHOT.12.09.1--------------------------------..12