Skip to content

Commit 5e7d903

Browse files
committed
Enabled optimized mode for redis
1 parent ff8c2ff commit 5e7d903

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

splitio/client/factory.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,9 +424,10 @@ def _build_redis_factory(api_key, cfg):
424424
_MIN_DEFAULT_DATA_SAMPLING_ALLOWED)
425425
data_sampling = _MIN_DEFAULT_DATA_SAMPLING_ALLOWED
426426

427+
imp_strategy = StrategyDebugMode() if cfg['impressionsMode'] == ImpressionsMode.DEBUG else StrategyOptimizedMode(ImpressionsCounter())
427428
imp_manager = ImpressionsManager(
428429
_wrap_impression_listener(cfg['impressionListener'], sdk_metadata),
429-
StrategyDebugMode())
430+
imp_strategy)
430431

431432
recorder = PipelinedRecorder(
432433
redis_adapter.pipeline,

splitio/storage/redis.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -431,6 +431,8 @@ def put(self, impressions):
431431
:return: Whether the impression has been added or not.
432432
:rtype: bool
433433
"""
434+
if impressions == []:
435+
return False
434436
bulk_impressions = self._wrap_impressions(impressions)
435437
try:
436438
inserted = self._redis.rpush(self.IMPRESSIONS_QUEUE_KEY, *bulk_impressions)

0 commit comments

Comments
 (0)