Skip to content

Commit 5da06df

Browse files
committed
added label prefix
1 parent d9bbce4 commit 5da06df

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

splitio/models/fallback_treatment.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ def __init__(self, treatment, config=None):
1818
self._config = None
1919
if config != None:
2020
self._config = json.dumps(config)
21+
self._label_prefix = "fallback - "
2122

2223
@property
2324
def treatment(self):
@@ -27,4 +28,9 @@ def treatment(self):
2728
@property
2829
def config(self):
2930
"""Return config."""
30-
return self._config
31+
return self._config
32+
33+
@property
34+
def label_prefix(self):
35+
"""Return label prefix."""
36+
return self._label_prefix

tests/client/test_config.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,13 @@ def test_sanitize(self, mocker):
109109
fb = FallbackTreatmentsConfiguration(FallbackConfig(FallbackTreatment('on')))
110110
processed = config.sanitize('some', {'fallbackTreatmentsConfiguration': fb})
111111
assert processed['fallbackTreatmentsConfiguration'].fallback_config.global_fallback_treatment.treatment == fb.fallback_config.global_fallback_treatment.treatment
112+
assert processed['fallbackTreatmentsConfiguration'].fallback_config.global_fallback_treatment.label_prefix == "fallback - "
112113

113114
fb = FallbackTreatmentsConfiguration(FallbackConfig(FallbackTreatment('on'), {"flag": FallbackTreatment("off")}))
114115
processed = config.sanitize('some', {'fallbackTreatmentsConfiguration': fb})
115116
assert processed['fallbackTreatmentsConfiguration'].fallback_config.global_fallback_treatment.treatment == fb.fallback_config.global_fallback_treatment.treatment
116117
assert processed['fallbackTreatmentsConfiguration'].fallback_config.by_flag_fallback_treatment["flag"] == fb.fallback_config.by_flag_fallback_treatment["flag"]
118+
assert processed['fallbackTreatmentsConfiguration'].fallback_config.by_flag_fallback_treatment["flag"].label_prefix == "fallback - "
117119

118120
_logger.reset_mock()
119121
fb = FallbackTreatmentsConfiguration(FallbackConfig(None, {"flag#%": FallbackTreatment("off"), "flag2": FallbackTreatment("on")}))

0 commit comments

Comments
 (0)