Fixed integrations tests

Author: chillaq

splitio/storage/redis.py

@@ -195,11 +195,23 @@ def get_splits_count(self):
     def get_all_splits(self):
         """
         Return all the splits in cache.
-
-        :return: 0
-        :rtype: int
+        :return: List of all splits in cache.
+        :rtype: list(splitio.models.splits.Split)
         """
-        return 0
+        keys = self._redis.keys(self._get_key('*'))
+        to_return = []
+        try:
+            raw_splits = self._redis.mget(keys)
+            for raw in raw_splits:
+                try:
+                    to_return.append(splits.from_raw(json.loads(raw)))
+                except (ValueError, TypeError):
+                    _LOGGER.error('Could not parse split. Skipping')
+                    _LOGGER.debug("Raw split that failed parsing attempt: %s", raw)
+        except RedisAdapterException:
+            _LOGGER.error('Error fetching all splits from storage')
+            _LOGGER.debug('Error: ', exc_info=True)
+        return to_return
 
     def kill_locally(self, split_name, default_treatment, change_number):
         """

tests/integration/test_client_e2e.py

@@ -12,7 +12,7 @@
 from splitio.storage.inmemmory import InMemoryEventStorage, InMemoryImpressionStorage, \
     InMemorySegmentStorage, InMemorySplitStorage, InMemoryTelemetryStorage
 from splitio.storage.redis import RedisEventsStorage, RedisImpressionsStorage, \
-    RedisSplitStorage, RedisSegmentStorage
+    RedisSplitStorage, RedisSegmentStorage, RedisTelemetryStorage
 from splitio.storage.adapters.redis import build, RedisAdapter
 from splitio.models import splits, segments
 from splitio.engine.impressions.impressions import Manager as ImpressionsManager, ImpressionsMode
@@ -53,6 +53,7 @@ def setup_method(self):
         telemetry_producer = TelemetryStorageProducer(telemetry_storage)
         telemetry_consumer = TelemetryStorageConsumer(telemetry_storage)
         telemetry_runtime_producer = telemetry_producer.get_telemetry_runtime_producer()
+        telemetry_evaluation_producer = telemetry_producer.get_telemetry_evaluation_producer()
 
         storages = {
             'splits': split_storage,
@@ -61,7 +62,7 @@ def setup_method(self):
             'events': InMemoryEventStorage(5000, telemetry_runtime_producer),
         }
         impmanager = ImpressionsManager(StrategyDebugMode(), telemetry_runtime_producer) # no listener
-        recorder = StandardRecorder(impmanager, storages['events'], storages['impressions'])
+        recorder = StandardRecorder(impmanager, storages['events'], storages['impressions'], telemetry_evaluation_producer)
         self.factory = SplitFactory('some_api_key',
                                     storages,
                                     True,
@@ -313,6 +314,7 @@ def setup_method(self):
         telemetry_producer = TelemetryStorageProducer(telemetry_storage)
         telemetry_consumer = TelemetryStorageConsumer(telemetry_storage)
         telemetry_runtime_producer = telemetry_producer.get_telemetry_runtime_producer()
+        telemetry_evaluation_producer = telemetry_producer.get_telemetry_evaluation_producer()
 
         storages = {
             'splits': split_storage,
@@ -321,7 +323,7 @@ def setup_method(self):
             'events': InMemoryEventStorage(5000, telemetry_runtime_producer),
         }
         impmanager = ImpressionsManager(StrategyOptimizedMode(ImpressionsCounter()), telemetry_runtime_producer) # no listener
-        recorder = StandardRecorder(impmanager, storages['events'], storages['impressions'])
+        recorder = StandardRecorder(impmanager, storages['events'], storages['impressions'], telemetry_evaluation_producer)
         self.factory = SplitFactory('some_api_key',
                                     storages,
                                     True,
@@ -539,9 +541,9 @@ def setup_method(self):
         redis_client.sadd(segment_storage._get_key(data['name']), *data['added'])
         redis_client.set(segment_storage._get_till_key(data['name']), data['till'])
 
-        telemetry_storage = InMemoryTelemetryStorage()
-        telemetry_producer = TelemetryStorageProducer(telemetry_storage)
-        telemetry_consumer = TelemetryStorageConsumer(telemetry_storage)
+        telemetry_redis_storage = RedisTelemetryStorage(redis_client, metadata)
+        telemetry_producer = TelemetryStorageProducer(telemetry_redis_storage)
+        telemetry_consumer = TelemetryStorageConsumer(telemetry_redis_storage)
         telemetry_runtime_producer = telemetry_producer.get_telemetry_runtime_producer()
 
         storages = {
@@ -551,8 +553,8 @@ def setup_method(self):
             'events': RedisEventsStorage(redis_client, metadata),
         }
         impmanager = ImpressionsManager(StrategyDebugMode(), telemetry_runtime_producer) # no listener
-        recorder = PipelinedRecorder(redis_client.pipeline, impmanager,
-                                     storages['events'], storages['impressions'])
+        recorder = PipelinedRecorder(redis_client.pipeline, impmanager, storages['events'],
+                                    storages['impressions'], telemetry_redis_storage)
         self.factory = SplitFactory('some_api_key',
                                     storages,
                                     True,
@@ -827,10 +829,10 @@ def setup_method(self):
         redis_client.sadd(segment_storage._get_key(data['name']), *data['added'])
         redis_client.set(segment_storage._get_till_key(data['name']), data['till'])
 
-        telemetry_storage = InMemoryTelemetryStorage()
-        telemetry_producer = TelemetryStorageProducer(telemetry_storage)
+        telemetry_redis_storage = RedisTelemetryStorage(redis_client, metadata)
+        telemetry_producer = TelemetryStorageProducer(telemetry_redis_storage)
+        telemetry_consumer = TelemetryStorageConsumer(telemetry_redis_storage)
         telemetry_runtime_producer = telemetry_producer.get_telemetry_runtime_producer()
-        telemetry_consumer = TelemetryStorageConsumer(telemetry_storage)
         telemetry_runtime_producer = telemetry_producer.get_telemetry_runtime_producer()
 
         storages = {
@@ -841,7 +843,7 @@ def setup_method(self):
         }
         impmanager = ImpressionsManager(StrategyDebugMode(), telemetry_runtime_producer) # no listener
         recorder = PipelinedRecorder(redis_client.pipeline, impmanager,
-                                     storages['events'], storages['impressions'])
+                                     storages['events'], storages['impressions'], telemetry_redis_storage)
         self.factory = SplitFactory('some_api_key',
                                     storages,
                                     True,