fixed pluggable and redis async factory calls

fixed tests
added listener base class

Author: Bilal Al

splitio/client/factory.py

@@ -887,7 +887,6 @@ async def _build_redis_factory_async(api_key, cfg):
         cfg['labelsEnabled'],
         recorder,
         manager,
-        sdk_ready_flag=None,
         telemetry_producer=telemetry_producer,
         telemetry_init_producer=telemetry_init_producer,
         telemetry_submitter=telemetry_submitter
@@ -1048,7 +1047,6 @@ async def _build_pluggable_factory_async(api_key, cfg):
         cfg['labelsEnabled'],
         recorder,
         manager,
-        sdk_ready_flag=None,
         telemetry_producer=telemetry_producer,
         telemetry_init_producer=telemetry_init_producer,
         telemetry_submitter=telemetry_submitter
@@ -1192,7 +1190,6 @@ async def _build_localhost_factory_async(cfg):
         False,
         recorder,
         manager,
-        None,
         telemetry_producer=telemetry_producer,
         telemetry_init_producer=telemetry_producer.get_telemetry_init_producer(),
         telemetry_submitter=LocalhostTelemetrySubmitterAsync(),

splitio/client/listener.py

@@ -21,6 +21,28 @@ def log_impression(self, data):
         """
         pass
 
+class ImpressionListenerBase(ImpressionListener):  # pylint: disable=too-few-public-methods
+    """
+    Impression listener safe-execution wrapper.
+
+    Wrapper in charge of building all the data that client would require in case
+    of adding some logic with the treatment and impression results.
+    """
+
+    impression_listener = None
+
+    def __init__(self, impression_listener, sdk_metadata):
+        """
+        Class Constructor.
+
+        :param impression_listener: User provided impression listener.
+        :type impression_listener: ImpressionListener
+        :param sdk_metadata: SDK version, instance name & IP
+        :type sdk_metadata: splitio.client.util.SdkMetadata
+        """
+        self.impression_listener = impression_listener
+        self._metadata = sdk_metadata
+
     def _construct_data(self, impression, attributes):
         data = {}
         data['impression'] = impression
@@ -29,16 +51,16 @@ def _construct_data(self, impression, attributes):
         data['instance-id'] = self._metadata.instance_name
         return data
 
-class ImpressionListenerWrapper(ImpressionListener):  # pylint: disable=too-few-public-methods
+    def log_impression(self, impression, attributes=None):
+        pass
+
+class ImpressionListenerWrapper(ImpressionListenerBase):  # pylint: disable=too-few-public-methods
     """
     Impression listener safe-execution wrapper.
 
     Wrapper in charge of building all the data that client would require in case
     of adding some logic with the treatment and impression results.
     """
-
-    impression_listener = None
-
     def __init__(self, impression_listener, sdk_metadata):
         """
         Class Constructor.
@@ -48,8 +70,7 @@ def __init__(self, impression_listener, sdk_metadata):
         :param sdk_metadata: SDK version, instance name & IP
         :type sdk_metadata: splitio.client.util.SdkMetadata
         """
-        self.impression_listener = impression_listener
-        self._metadata = sdk_metadata
+        ImpressionListenerBase.__init__(self, impression_listener, sdk_metadata)
 
     def log_impression(self, impression, attributes=None):
         """
@@ -67,16 +88,13 @@ def log_impression(self, impression, attributes=None):
             raise ImpressionListenerException('Error in log_impression user\'s method is throwing exceptions') from exc
 
 
-class ImpressionListenerWrapperAsync(ImpressionListener):  # pylint: disable=too-few-public-methods
+class ImpressionListenerWrapperAsync(ImpressionListenerBase):  # pylint: disable=too-few-public-methods
     """
     Impression listener safe-execution wrapper.
 
     Wrapper in charge of building all the data that client would require in case
     of adding some logic with the treatment and impression results.
     """
-
-    impression_listener = None
-
     def __init__(self, impression_listener, sdk_metadata):
         """
         Class Constructor.
@@ -86,8 +104,7 @@ def __init__(self, impression_listener, sdk_metadata):
         :param sdk_metadata: SDK version, instance name & IP
         :type sdk_metadata: splitio.client.util.SdkMetadata
         """
-        self.impression_listener = impression_listener
-        self._metadata = sdk_metadata
+        ImpressionListenerBase.__init__(self, impression_listener, sdk_metadata)
 
     async def log_impression(self, impression, attributes=None):
         """