Skip to content

Commit 4b5281f

Browse files
authored
Merge pull request #270 from splitio/redis-optimized
Enabled optimized mode for redis
2 parents ff8c2ff + 17b5975 commit 4b5281f

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

splitio/client/factory.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,9 +424,10 @@ def _build_redis_factory(api_key, cfg):
424424
_MIN_DEFAULT_DATA_SAMPLING_ALLOWED)
425425
data_sampling = _MIN_DEFAULT_DATA_SAMPLING_ALLOWED
426426

427+
imp_strategy = StrategyDebugMode() if cfg['impressionsMode'] == ImpressionsMode.DEBUG else StrategyOptimizedMode(ImpressionsCounter())
427428
imp_manager = ImpressionsManager(
428429
_wrap_impression_listener(cfg['impressionListener'], sdk_metadata),
429-
StrategyDebugMode())
430+
imp_strategy)
430431

431432
recorder = PipelinedRecorder(
432433
redis_adapter.pipeline,

splitio/recorder/recorder.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,8 @@ def record_treatment_stats(self, impressions, latency, operation):
129129
if self._data_sampling < rnumber:
130130
return
131131
impressions = self._impressions_manager.process_impressions(impressions)
132+
if impressions == []:
133+
return
132134
# pipe = self._make_pipe()
133135
# self._impression_storage.add_impressions_to_pipe(impressions, pipe)
134136
# self._telemetry_storage.add_latency_to_pipe(operation, latency, pipe)

0 commit comments

Comments
 (0)