polish

Author: chillaq

splitio/storage/pluggable.py

@@ -28,7 +28,6 @@ def __init__(self, pluggable_adapter, prefix=None, config_flag_sets=[]):
         :type prefix: str
         """
         self._pluggable_adapter = pluggable_adapter
-        self._config_flag_sets = config_flag_sets
         self._prefix = "SPLITIO.split.{feature_flag_name}"
         self._traffic_type_prefix = "SPLITIO.trafficType.{traffic_type_name}"
         self._feature_flag_till_prefix = "SPLITIO.splits.till"
@@ -81,8 +80,8 @@ def get_feature_flags_by_sets(self, flag_sets):
         """
         Retrieve feature flags by flag set.
 
-        :param flag_set: Names of the flag set to fetch.
-        :type flag_set: str
+        :param flag_sets: List of flag sets to fetch.
+        :type flag_sets: list(str)
 
         :return: Feature flag names that are tagged with the flag set
         :rtype: listt(str)

splitio/storage/redis.py

@@ -22,7 +22,7 @@ class RedisSplitStorage(SplitStorage):
     _FEATURE_FLAG_KEY = 'SPLITIO.split.{feature_flag_name}'
     _FEATURE_FLAG_TILL_KEY = 'SPLITIO.splits.till'
     _TRAFFIC_TYPE_KEY = 'SPLITIO.trafficType.{traffic_type_name}'
-    _SET_KEY = 'SPLITIO.flagSet.{flag_set}'
+    _FLAG_SET_KEY = 'SPLITIO.flagSet.{flag_set}'
 
     def __init__(self, redis_client, enable_caching=False, max_age=DEFAULT_MAX_AGE, config_flag_sets=[]):
         """
@@ -63,7 +63,7 @@ def _get_traffic_type_key(self, traffic_type_name):
         """
         return self._TRAFFIC_TYPE_KEY.format(traffic_type_name=traffic_type_name)
 
-    def _get_set_key(self, flag_set):
+    def _get_flag_set_key(self, flag_set):
         """
         Use the provided flag set to build the appropriate redis key.
 
@@ -73,7 +73,7 @@ def _get_set_key(self, flag_set):
         :return: Redis key.
         :rtype: str.
         """
-        return self._SET_KEY.format(flag_set=flag_set)
+        return self._FLAG_SET_KEY.format(flag_set=flag_set)
 
     def get(self, feature_flag_name):  # pylint: disable=method-hidden
         """
@@ -110,7 +110,7 @@ def get_feature_flags_by_sets(self, flag_sets):
             if sets_to_fetch == []:
                 return []
 
-            keys = [self._get_set_key(flag_set) for flag_set in sets_to_fetch]
+            keys = [self._get_flag_set_key(flag_set) for flag_set in sets_to_fetch]
             pipe = self._pipe()
             [pipe.smembers(key) for key in keys]
             result_sets = pipe.execute()