Skip to content

Commit 4375445

Browse files
committed
Combined test.engine.telemetry tests into 2 classes
1 parent 084fd02 commit 4375445

File tree

1 file changed

+2
-21
lines changed

1 file changed

+2
-21
lines changed

tests/engine/test_telemetry.py

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
class TelemetryStorageProducerTests(object):
88
"""TelemetryStorageProducer test."""
99

10-
def test_instances(self):
10+
def test_producer_instances(self):
1111
telemetry_storage = InMemoryTelemetryStorage()
1212
telemetry_producer = TelemetryStorageProducer(telemetry_storage)
1313

@@ -19,9 +19,6 @@ def test_instances(self):
1919
assert(telemetry_producer._telemetry_init_producer == telemetry_producer.get_telemetry_init_producer())
2020
assert(telemetry_producer._telemetry_runtime_producer == telemetry_producer.get_telemetry_runtime_producer())
2121

22-
class TelemetryInitProducerTest(object):
23-
"""TelemetryInitProducer test."""
24-
2522
def test_record_config(self, mocker):
2623
telemetry_storage = mocker.Mock()
2724
telemetry_init_producer = TelemetryInitProducer(telemetry_storage)
@@ -30,7 +27,7 @@ def record_config(*args, **kwargs):
3027
self.passed_config = args[0]
3128

3229
telemetry_storage.record_config.side_effect = record_config
33-
telemetry_init_producer.record_config({'bT':0, 'nR':0, 'uC': 0})
30+
telemetry_init_producer.record_config({'bT':0, 'nR':0, 'uC': 0}, {})
3431
assert(self.passed_config == {'bT':0, 'nR':0, 'uC': 0})
3532

3633
def test_record_ready_time(self, mocker):
@@ -58,9 +55,6 @@ def test_record_not_ready_usage(self, mocker):
5855
telemetry_init_producer.record_not_ready_usage()
5956
assert(mocker.called)
6057

61-
class TelemetryEvaluationProducerTest(object):
62-
"""Telemetry evaluation producer test class."""
63-
6458
def test_record_latency(self, mocker):
6559
telemetry_storage = mocker.Mock()
6660
telemetry_evaluation_producer = TelemetryEvaluationProducer(telemetry_storage)
@@ -84,10 +78,6 @@ def record_exception(*args, **kwargs):
8478
telemetry_evaluation_producer.record_exception('method')
8579
assert(self.passed_method == 'method')
8680

87-
88-
class TelemetryRuntimeProducerTest(object):
89-
"""Telemetry runtime producer test."""
90-
9181
def test_add_tag(self, mocker):
9282
telemetry_storage = mocker.Mock()
9383
telemetry_runtime_producer = TelemetryRuntimeProducer(telemetry_storage)
@@ -210,9 +200,6 @@ def test_instances(self):
210200
assert(telemetry_consumer._telemetry_init_consumer == telemetry_consumer.get_telemetry_init_consumer())
211201
assert(telemetry_consumer._telemetry_runtime_consumer == telemetry_consumer.get_telemetry_runtime_consumer())
212202

213-
class TelemetryInitConsumerTest(object):
214-
"""TelemetryInitConsumer test."""
215-
216203
@mock.patch('splitio.storage.inmemmory.InMemoryTelemetryStorage.get_bur_time_outs')
217204
def test_get_bur_time_outs(self, mocker):
218205
telemetry_storage = InMemoryTelemetryStorage()
@@ -234,9 +221,6 @@ def get_not_ready_usage(self, mocker):
234221
telemetry_init_consumer.get_config_stats()
235222
assert(mocker.called)
236223

237-
class TelemetryEvaluationConsumerTest(object):
238-
"""TelemetryEvaluationConsumer test."""
239-
240224
@mock.patch('splitio.storage.inmemmory.InMemoryTelemetryStorage.pop_exceptions')
241225
def pop_exceptions(self, mocker):
242226
telemetry_storage = InMemoryTelemetryStorage()
@@ -251,9 +235,6 @@ def pop_latencies(self, mocker):
251235
telemetry_evaluation_consumer.pop_latencies()
252236
assert(mocker.called)
253237

254-
class TelemetryRuntimeConsumerTest(object):
255-
"""TelemetryRuntimeConsumer test."""
256-
257238
def test_get_impressions_stats(self, mocker):
258239
telemetry_storage = mocker.Mock()
259240
telemetry_runtime_consumer = TelemetryRuntimeConsumer(telemetry_storage)

0 commit comments

Comments
 (0)