Merge pull request #457 from splitio/flagsets-client-manager

added client.manager test, minor fix in models.splits and updated con…

Author: chillaq

splitio/client/config.py

@@ -60,7 +60,7 @@
     'storageWrapper': None,
     'storagePrefix': None,
     'storageType': None,
-    'FlagSets': None
+    'FlagSetsFilter': None
 }
 
 def _parse_operation_mode(sdk_key, config):
@@ -179,6 +179,6 @@ def sanitize(sdk_key, config):
         _LOGGER.warning('metricRefreshRate parameter minimum value is 60 seconds, defaulting to 3600 seconds.')
         processed['metricsRefreshRate'] = 3600
 
-    processed['FlagSets'] = _sanitize_flag_sets(processed['FlagSets']) if processed['FlagSets'] is not None else None
+    processed['FlagSetsFilter'] = sanitize_flag_sets(processed['FlagSetsFilter']) if processed['FlagSetsFilter'] is not None else None
 
     return processed

splitio/models/splits.py

@@ -200,7 +200,7 @@ def to_split_view(self):
             list(set(part.treatment for cond in self.conditions for part in cond.partitions)),
             self.change_number,
             self._configurations if self._configurations is not None else {},
-            self._sets
+            self._sets if self._sets is not None else []
         )
 
     def local_kill(self, default_treatment, change_number):

tests/client/test_manager.py

@@ -1,13 +1,15 @@
 """SDK main manager test module."""
+import pytest
 
 from splitio.client.factory import SplitFactory
 from splitio.client.manager import SplitManager, _LOGGER as _logger
 from splitio.storage import SplitStorage, EventStorage, ImpressionStorage, SegmentStorage
-from splitio.storage.inmemmory import InMemoryTelemetryStorage
+from splitio.storage.inmemmory import InMemoryTelemetryStorage, InMemorySplitStorage
+from splitio.models import splits
 from splitio.engine.impressions.impressions import Manager as ImpressionManager
 from splitio.engine.telemetry import TelemetryStorageProducer, TelemetryStorageConsumer
 from splitio.recorder.recorder import StandardRecorder
-
+from tests.models.test_splits import SplitTests
 
 class ManagerTests(object):  # pylint: disable=too-few-public-methods
     """Split manager test cases."""
@@ -19,7 +21,6 @@ def test_evaluations_before_running_post_fork(self, mocker):
         impmanager = mocker.Mock(spec=ImpressionManager)
         telemetry_storage = InMemoryTelemetryStorage()
         telemetry_producer = TelemetryStorageProducer(telemetry_storage)
-        telemetry_consumer = TelemetryStorageConsumer(telemetry_storage)
         recorder = StandardRecorder(impmanager, mocker.Mock(), mocker.Mock(), telemetry_producer.get_telemetry_evaluation_producer())
         factory = SplitFactory(mocker.Mock(),
             {'splits': mocker.Mock(),
@@ -55,3 +56,44 @@ def test_evaluations_before_running_post_fork(self, mocker):
         assert manager.splits() == []
         assert _logger.error.mock_calls == expected_msg
         _logger.reset_mock()
+
+    def test_manager_calls(self, mocker):
+        split_storage = InMemorySplitStorage()
+        split = splits.from_raw(SplitTests.raw)
+        split_storage.update([split], [], 123)
+        factory = SplitFactory(mocker.Mock(),
+            {'splits': split_storage,
+            'segments': mocker.Mock(),
+            'impressions': mocker.Mock(),
+            'events': mocker.Mock()},
+            mocker.Mock(),
+            mocker.Mock(),
+            mocker.Mock(),
+            mocker.Mock(),
+            mocker.Mock(),
+            mocker.Mock(),
+            mocker.Mock(),
+            False
+        )
+        manager = SplitManager(factory)
+        splits_view = manager.splits()
+        self._verify_split(splits_view[0])
+        assert manager.split_names() == ['some_name']
+        split_view = manager.split('some_name')
+        self._verify_split(split_view)
+        split2 = SplitTests.raw.copy()
+        split2['sets'] = None
+        split2['name'] = 'no_sets_split'
+        split_storage.update([splits.from_raw(split2)], [], 123)
+
+        split_view = manager.split('no_sets_split')
+        assert split_view.sets == []
+
+    def _verify_split(self, split):
+        assert split.name == 'some_name'
+        assert split.traffic_type == 'user'
+        assert split.killed == False
+        assert sorted(split.treatments) == ['off', 'on']
+        assert split.change_number == 123
+        assert split.configs == {'on': '{"color": "blue", "size": 13}'}
+        assert split.sets == ['set1', 'set2']