replaced split with feature flag

Author: chillaq

splitio/push/parser.py

@@ -276,7 +276,7 @@ def __str__(self):
 
 
 class BaseUpdate(BaseMessage, metaclass=abc.ABCMeta):
-    """Split data update notification."""
+    """Feature flag data update notification."""
 
     def __init__(self, channel, timestamp, change_number):
         """
@@ -323,13 +323,13 @@ def change_number(self):
 
 
 class SplitChangeUpdate(BaseUpdate):
-    """Split Change notification."""
+    """Feature flag Change notification."""
 
-    def __init__(self, channel, timestamp, change_number, previous_change_number, split_definition, compression):
+    def __init__(self, channel, timestamp, change_number, previous_change_number, feature_flag_definition, compression):
         """Class constructor."""
         BaseUpdate.__init__(self, channel, timestamp, change_number)
         self._previous_change_number = previous_change_number
-        self._split_definition = split_definition
+        self._feature_flag_definition = feature_flag_definition
         self._compression = compression
 
     @property
@@ -353,14 +353,14 @@ def previous_change_number(self):  # pylint:disable=no-self-use
         return self._previous_change_number
 
     @property
-    def split_definition(self):  # pylint:disable=no-self-use
+    def feature_flag_definition(self):  # pylint:disable=no-self-use
         """
-        Return split definition
+        Return feature flag definition
 
-        :returns: The new split definition
+        :returns: The new feature flag definition
         :rtype: str
         """
-        return self._split_definition
+        return self._feature_flag_definition
 
     @property
     def compression(self):  # pylint:disable=no-self-use
@@ -378,12 +378,12 @@ def __str__(self):
 
 
 class SplitKillUpdate(BaseUpdate):
-    """Split Kill notification."""
+    """Feature flag Kill notification."""
 
-    def __init__(self, channel, timestamp, change_number, split_name, default_treatment):  # pylint:disable=too-many-arguments
+    def __init__(self, channel, timestamp, change_number, feature_flag_name, default_treatment):  # pylint:disable=too-many-arguments
         """Class constructor."""
         BaseUpdate.__init__(self, channel, timestamp, change_number)
-        self._split_name = split_name
+        self._feature_flag_name = feature_flag_name
         self._default_treatment = default_treatment
 
     @property
@@ -397,14 +397,14 @@ def update_type(self):  # pylint:disable=no-self-use
         return UpdateType.SPLIT_KILL
 
     @property
-    def split_name(self):
+    def feature_flag_name(self):
         """
-        Return the name of the killed split.
+        Return the name of the killed feature flag.
 
-        :returns: name of the killed split
+        :returns: name of the killed feature flag
         :rtype: str
         """
-        return self._split_name
+        return self._feature_flag_name
 
     @property
     def default_treatment(self):
@@ -419,7 +419,7 @@ def default_treatment(self):
     def __str__(self):
         """Return string representation."""
         return "SplitKill - changeNumber=%d, name=%s, defaultTreatment=%s" % \
-            (self.change_number, self.split_name, self.default_treatment)
+            (self.change_number, self.feature_flag, self.default_treatment)
 
 
 class SegmentChangeUpdate(BaseUpdate):

tests/push/test_parser.py

@@ -55,7 +55,7 @@ def test_event_parsing(self):
         assert isinstance(parsed0, SplitKillUpdate)
         assert parsed0.default_treatment == 'some'
         assert parsed0.change_number == 1591996754396
-        assert parsed0.split_name == 'test'
+        assert parsed0.feature_flag_name == 'test'
 
         e1 = make_message(
             'NDA5ODc2MTAyNg==_MzAyODY0NDkyOA==_splits',
@@ -66,7 +66,7 @@ def test_event_parsing(self):
         assert parsed1.change_number == 1591996685190
         assert parsed1.previous_change_number == 12
         assert parsed1.compression == 2
-        assert parsed1.split_definition == 'eJzEUtFu2kAQ/BU0z4d0hw2Be0MFRVGJIx'
+        assert parsed1.feature_flag_definition == 'eJzEUtFu2kAQ/BU0z4d0hw2Be0MFRVGJIx'
 
         e1 = make_message(
             'NDA5ODc2MTAyNg==_MzAyODY0NDkyOA==_splits',
@@ -77,7 +77,7 @@ def test_event_parsing(self):
         assert parsed1.change_number == 1591996685190
         assert parsed1.previous_change_number == None
         assert parsed1.compression == None
-        assert parsed1.split_definition == None
+        assert parsed1.feature_flag_definition == None
 
 
         e2 = make_message(