polishing and pushed telemetry post as final event.

Author: chillaq

splitio/api/client.py

@@ -108,8 +108,7 @@ def get(self, server, path, apikey, query=None, extra_headers=None):  # pylint:
                 headers=headers,
                 timeout=self._timeout
             )
-            response = HttpResponse(response.status_code, response.text)
-            return response
+            return HttpResponse(response.status_code, response.text)
         except Exception as exc:  # pylint: disable=broad-except
             raise HttpClientException('requests library is throwing exceptions') from exc
 
@@ -146,7 +145,6 @@ def post(self, server, path, apikey, body, query=None, extra_headers=None):  # p
                 headers=headers,
                 timeout=self._timeout
             )
-            response = HttpResponse(response.status_code, response.text)
-            return response
+            return HttpResponse(response.status_code, response.text)
         except Exception as exc:  # pylint: disable=broad-except
             raise HttpClientException('requests library is throwing exceptions') from exc

splitio/api/commons.py

@@ -51,8 +51,8 @@ def record_telemetry(status_code, elapsed, metric_name, telemetry_runtime_produc
     telemetry_runtime_producer.record_sync_latency(metric_name, elapsed)
     if 200 <= status_code < 300:
         telemetry_runtime_producer.record_successful_sync(metric_name, get_current_epoch_time())
-    else:
-        telemetry_runtime_producer.record_sync_error(metric_name, status_code)
+        return
+    telemetry_runtime_producer.record_sync_error(metric_name, status_code)
 
 class FetchOptions(object):
     """Fetch Options object."""

splitio/client/client.py

@@ -408,12 +408,15 @@ def track(self, key, traffic_type, event_type, value=None, properties=None):
             properties=properties,
         )
 
-        return_flag = self._recorder.record_track_stats([EventWrapper(
-            event=event,
-            size=size,
-        )])
-        self._telemetry_evaluation_producer.record_latency(TRACK, get_current_epoch_time() - start)
-        if not return_flag:
+        try:
+            return_flag = self._recorder.record_track_stats([EventWrapper(
+                event=event,
+                size=size,
+            )])
+            self._telemetry_evaluation_producer.record_latency(TRACK, get_current_epoch_time() - start)
+        except Exception:  # pylint: disable=broad-except
             self._telemetry_evaluation_producer.record_exception(TRACK)
+            _LOGGER.error('Error processing track event')
+            _LOGGER.debug('Error: ', exc_info=True)
 
         return return_flag

splitio/sync/synchronizer.py

@@ -361,11 +361,14 @@ def stop_periodic_data_recording(self, blocking):
         if blocking:
             events = []
             for task in self._periodic_data_recording_tasks:
-                stop_event = threading.Event()
-                task.stop(stop_event)
-                events.append(stop_event)
-                time.sleep(0.4)
-            if all(event.wait() for event in events):
+                if task != self._split_tasks.telemetry_task:
+                    stop_event = threading.Event()
+                    task.stop(stop_event)
+                    events.append(stop_event)
+            all(event.wait() for event in events)
+            telemetry_event = threading.Event()
+            self._split_tasks.telemetry_task.stop(telemetry_event)
+            if telemetry_event.wait():
                 _LOGGER.debug('all tasks finished successfully.')
         else:
             for task in self._periodic_data_recording_tasks: