Skip to content

Commit 3055fb9

Browse files
committed
updated tests
1 parent 529c177 commit 3055fb9

File tree

2 files changed

+260
-53
lines changed

2 files changed

+260
-53
lines changed

splitio/client/client.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
"""A module for Split.io SDK API clients."""
22
import logging
3+
import json
34

45
from splitio.engine.evaluator import Evaluator, CONTROL, EvaluationDataFactory, AsyncEvaluationDataFactory
56
from splitio.engine.splitters import Splitter
@@ -135,13 +136,14 @@ def _build_impression(self, key, bucketing, feature, result, properties=None):
135136
change_number=result['impression']['change_number'],
136137
bucketing_key=bucketing,
137138
time=utctime_ms(),
138-
impression_properties=properties),
139+
previous_time=None,
140+
properties=json.dumps(properties)),
139141
disabled=result['impressions_disabled'])
140142

141-
def _build_impressions(self, key, bucketing, results):
143+
def _build_impressions(self, key, bucketing, results, properties=None):
142144
"""Build an impression based on evaluation data & it's result."""
143145
return [
144-
self._build_impression(key, bucketing, feature, result)
146+
self._build_impression(key, bucketing, feature, result, properties)
145147
for feature, result in results.items()
146148
]
147149

@@ -568,7 +570,7 @@ def _get_treatments(self, key, features, method, attributes=None, impressions_pr
568570
self._telemetry_init_producer.record_not_ready_usage()
569571

570572
try:
571-
key, bucketing, features, attributes = self._validate_treatments_input(key, features, attributes, method, impressions_properties)
573+
key, bucketing, features, attributes, impressions_properties = self._validate_treatments_input(key, features, attributes, method, impressions_properties)
572574
except _InvalidInputError:
573575
return input_validator.generate_control_treatments(features)
574576

@@ -957,7 +959,7 @@ async def _get_treatments(self, key, features, method, attributes=None, impressi
957959
await self._telemetry_init_producer.record_not_ready_usage()
958960

959961
try:
960-
key, bucketing, features, attributes = self._validate_treatments_input(key, features, attributes, method, impressions_properties)
962+
key, bucketing, features, attributes, impressions_properties = self._validate_treatments_input(key, features, attributes, method, impressions_properties)
961963
except _InvalidInputError:
962964
return input_validator.generate_control_treatments(features)
963965

0 commit comments

Comments
 (0)