polish

Author: Bilal Al

splitio/engine/evaluator.py

@@ -68,7 +68,7 @@ def eval_with_context(self, key, bucketing, feature_name, attrs, ctx):
                 'label': label,
                 'change_number': _change_number
             },
-            'impressions_disabled': feature.impressionsDisabled if feature else None
+            'impressions_disabled': feature.impressions_disabled if feature else None
         }
 
     def _treatment_for_flag(self, flag, key, bucketing, attributes, ctx):

splitio/models/splits.py

@@ -74,7 +74,7 @@ def __init__(  # pylint: disable=too-many-arguments
             traffic_allocation_seed=None,
             configurations=None,
             sets=None,
-            impressionsDisabled=None
+            impressions_disabled=None
     ):
         """
         Class constructor.
@@ -97,8 +97,8 @@ def __init__(  # pylint: disable=too-many-arguments
         :type traffic_allocation_seed: int
         :pram sets: list of flag sets
         :type sets: list
-        :pram impressionsDisabled: track impressions flag
-        :type impressionsDisabled: boolean
+        :pram impressions_disabled: track impressions flag
+        :type impressions_disabled: boolean
         """
         self._name = name
         self._seed = seed
@@ -128,7 +128,7 @@ def __init__(  # pylint: disable=too-many-arguments
 
         self._configurations = configurations
         self._sets = set(sets) if sets is not None else set()
-        self._impressionsDisabled = impressionsDisabled if impressionsDisabled is not None else False
+        self._impressions_disabled = impressions_disabled if impressions_disabled is not None else False
 
     @property
     def name(self):
@@ -191,9 +191,9 @@ def sets(self):
         return self._sets
 
     @property
-    def impressionsDisabled(self):
-        """Return impressionsDisabled of the split."""
-        return self._impressionsDisabled
+    def impressions_disabled(self):
+        """Return impressions_disabled of the split."""
+        return self._impressions_disabled
 
     def get_configurations_for(self, treatment):
         """Return the mapping of treatments to configurations."""
@@ -224,7 +224,7 @@ def to_json(self):
             'conditions': [c.to_json() for c in self.conditions],
             'configurations': self._configurations,
             'sets': list(self._sets),
-            'impressionsDisabled': self._impressionsDisabled
+            'impressionsDisabled': self._impressions_disabled
         }
 
     def to_split_view(self):
@@ -243,7 +243,7 @@ def to_split_view(self):
             self._configurations if self._configurations is not None else {},
             self._default_treatment,
             list(self._sets) if self._sets is not None else [],
-            self._impressionsDisabled
+            self._impressions_disabled
         )
 
     def local_kill(self, default_treatment, change_number):
@@ -300,5 +300,5 @@ def from_raw(raw_split):
         traffic_allocation_seed=raw_split.get('trafficAllocationSeed'),
         configurations=raw_split.get('configurations'),
         sets=set(raw_split.get('sets')) if raw_split.get('sets') is not None else [],
-        impressionsDisabled=raw_split.get('impressionsDisabled') if raw_split.get('impressionsDisabled') is not None else False
+        impressions_disabled=raw_split.get('impressionsDisabled') if raw_split.get('impressionsDisabled') is not None else False
     )

tests/engine/test_evaluator.py

@@ -52,7 +52,7 @@ def test_evaluate_treatment_ok(self, mocker):
         assert result['impression']['change_number'] == 123
         assert result['impression']['label'] == 'some_label'
         assert mocked_split.get_configurations_for.mock_calls == [mocker.call('on')]
-        assert result['impressions_disabled'] == mocked_split.impressionsDisabled
+        assert result['impressions_disabled'] == mocked_split.impressions_disabled
 
 
     def test_evaluate_treatment_ok_no_config(self, mocker):

tests/models/test_splits.py

@@ -82,7 +82,7 @@ def test_from_raw(self):
         assert parsed.get_configurations_for('on') == '{"color": "blue", "size": 13}'
         assert parsed._configurations == {'on': '{"color": "blue", "size": 13}'}
         assert parsed.sets == {'set1', 'set2'}
-        assert parsed.impressionsDisabled == False
+        assert parsed.impressions_disabled == False
 
     def test_get_segment_names(self, mocker):
         """Test fetching segment names."""