added prefix validation

Author: chillaq

splitio/client/input_validator.py

@@ -536,6 +536,11 @@ def validate_pluggable_adapter(config):
         _LOGGER.error("Expecting custom storage `wrapper` in options, but no valid wrapper instance was provided.")
         return False
 
+    if config.get('storagePrefix') is not None:
+        if not isinstance(config.get('storagePrefix'), str):
+            _LOGGER.error("Custom storage prefix should be string type only")
+            return False
+
     pluggable_adapter = config.get('storageWrapper')
     if not isinstance(pluggable_adapter, object):
         _LOGGER.error("Custom storage instance is not inherted from object class")

tests/client/test_input_validator.py

@@ -1259,3 +1259,9 @@ def test_validate_pluggable_adapter(self):
 
         # expected mock adapter should pass
         assert(input_validator.validate_pluggable_adapter({'storageType': 'PLUGGABLE', 'storageWrapper': self.mock_adapter4()}))
+
+        # using string type prefix should pass
+        assert(input_validator.validate_pluggable_adapter({'storageType': 'PLUGGABLE', 'storagePrefix': 'myprefix', 'storageWrapper': self.mock_adapter4()}))
+
+        # using non-string type prefix should not pass
+        assert(not input_validator.validate_pluggable_adapter({'storageType': 'PLUGGABLE', 'storagePrefix': 'myprefix', 123: self.mock_adapter4()}))